Small fix of Testcase as part of cleanup#3069
Open
yeswanth6096 wants to merge 1 commit intoavocado-framework-tests:masterfrom
Open
Small fix of Testcase as part of cleanup#3069yeswanth6096 wants to merge 1 commit intoavocado-framework-tests:masterfrom
yeswanth6096 wants to merge 1 commit intoavocado-framework-tests:masterfrom
Conversation
yeswanth6096
force-pushed
the
smt-state-dlpar-cleanupfix
branch
from
3d96750 to
95e4cf1
Compare
Naresh-ibm
requested changes
Nov 20, 2025
dlpar/dlpar_main.py
Outdated
| # Setting cpu online back after TC complete | ||
| set_cpu1_online = process.system_output( | ||
| 'echo 1 > /sys/devices/system/cpu/cpu1/online', | ||
| shell=True, ignore_status=False) |
Collaborator
There was a problem hiding this comment.
@yeswanth6096 why are you capturing the result in the variable? I don't see any other action performed on this variable
Collaborator
There was a problem hiding this comment.
also please use cmd = "echo 1 > /sys/devices/system/cpu/cpu1/online"
then use it in the process.run command
yeswanth6096
force-pushed
the
smt-state-dlpar-cleanupfix
branch
2 times, most recently
from
0881561 to
efa90c7
Compare
ok Done Signed-off-by: yeswanth <yeswanth@linux.ibm.com>
yeswanth6096
force-pushed
the
smt-state-dlpar-cleanupfix
branch
from
efa90c7 to
ca00816
Compare
Naresh-ibm
requested changes
Nov 21, 2025
| # Setting cpu online back after TC complete | ||
| cmd = 'echo 1 > /sys/devices/system/cpu/cpu1/online' | ||
| process.system_output( | ||
| cmd, shell=True, ignore_status=False) |
Collaborator
There was a problem hiding this comment.
@yeswanth6096 use process.run instead of process.system_output
Collaborator
|
Also please attach the run logs |
sacsant
suggested changes
Dec 2, 2025
Contributor
sacsant
left a comment
sacsant
left a comment
There was a problem hiding this comment.
Please add a proper commit message describing what the problem is and how does this change solves it.
Collaborator
|
@yeswanth6096 please address the review comments and re-push the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.