Skip to content

Added adapter details update and improve DRC validation#3071

Open
maramsmurthy wants to merge 1 commit intoavocado-framework-tests:masterfrom
maramsmurthy:msmurthy_dlpar_splitter_fix
Open

Added adapter details update and improve DRC validation#3071
maramsmurthy wants to merge 1 commit intoavocado-framework-tests:masterfrom
maramsmurthy:msmurthy_dlpar_splitter_fix

Conversation

@maramsmurthy
Copy link
Copy Markdown
Contributor

  • Added calls to set_adapter_details(pci) after each DLPAR add/move operation and after DRMGR PCI/PHB operations to ensure adapter details are refreshed before OS validation.
  • Updated DRC validation logic in dlpar_remove to check for specific drc_index in listhwres output, preventing false positives when other resources are listed.

- Added calls to `set_adapter_details(pci)` after each DLPAR add/move operation
  and after DRMGR PCI/PHB operations to ensure adapter details are refreshed
  before OS validation.
- Updated DRC validation logic in `dlpar_remove` to check for specific
  `drc_index` in `listhwres` output, preventing false positives when other
  resources are listed.

Signed-off-by: Maram Srimannarayana Murthy <msmurthy@linux.vnet.ibm.com>
@Naresh-ibm Naresh-ibm self-assigned this Nov 27, 2025
for _ in range(self.num_of_dlpar):
self.do_drmgr_phb('r')
self.do_drmgr_phb('a')
self.set_adapter_details(pci)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maramsmurthy where are we adding the details for /dev/disk/by-id/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naresh-ibm

I hope we no need to perform /dev/disk/by-id as it is just needed a namespace check.

Name space check is already available as follows in dlpar.py only

        current_namespaces = nvme.get_current_ns_ids(self.contr_name)
        if current_namespaces == self.ns_list:
            for ns_id in current_namespaces:
                status = nvme.get_ns_status(self.contr_name, ns_id)
                if not status[0] == 'live' and status[1] == 'optimized':
                    err_ns.append(ns_id)
        else:
            self.log.info("following ns not back listing after hot_plug" %
                          (self.ns_list - current_namespaces))

Please check and let me know if any other changes are required.

@maramsmurthy
Copy link
Copy Markdown
Contributor Author

Test is successful without any issues

avocado run --max-parallel-tasks=1 dlpar.py -m dlpar.py.data/dlpar.yaml

JOB ID : 7c056a37a32c8ede6713e202d9b735762e2c75af
JOB LOG : /home/OpTest/avocado-fvt-wrapper/results/job-2025-11-27T12.32-7c056a3/job.log
(1/3) dlpar.py:DlparPci.test_dlpar;run-lpar_2-peer_ip-1de0: STARTED
(1/3) dlpar.py:DlparPci.test_dlpar;run-lpar_2-peer_ip-1de0: PASS (260.80 s)
(2/3) dlpar.py:DlparPci.test_drmgr_pci;run-lpar_2-peer_ip-1de0: STARTED

(2/3) dlpar.py:DlparPci.test_drmgr_pci;run-lpar_2-peer_ip-1de0: PASS (647.49 s)
(3/3) dlpar.py:DlparPci.test_drmgr_phb;run-lpar_2-peer_ip-1de0: STARTED
(3/3) dlpar.py:DlparPci.test_drmgr_phb;run-lpar_2-peer_ip-1de0: PASS (255.05 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /home/OpTest/avocado-fvt-wrapper/results/job-2025-11-27T12.32-7c056a3/results.html
JOB TIME : 1181.82 s

@PraveenPenguin
Copy link
Copy Markdown
Member

@maramsmurthy @Naresh-ibm any update ?

@Naresh-ibm
Copy link
Copy Markdown
Collaborator

Naresh-ibm commented Mar 3, 2026

@maramsmurthy where are we on this PR?
are you still looking to add more here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants