VM_bootloader:provide bootloader's version for each arch #3786

MiriamDeng · 2023-10-23T08:34:18Z

ID:1456

MiriamDeng · 2023-10-23T09:09:38Z

Test results
(2/2) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.ppc64le.io-github-autotest-qemu.boot: STARTED
(2/2) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.ppc64le.io-github-autotest-qemu.boot: PASS (107.16 s)

[stdlog] 2023-10-23 04:19:11,094 avocado.utils.process INFO | Command 'rpm -qa|grep SLOF' finished with 0 after 1.331755701s
[stdlog] 2023-10-23 04:19:11,095 avocado.virttest.env_process DEBUG| SLOF version: SLOF-20210217-1.module+el8.9.0+18724+20190c23.noarch

MiriamDeng · 2023-10-24T05:39:11Z

@PaulYuuu @maxujun can you help to review this patch ? Thank you !

PaulYuuu · 2023-10-24T06:13:44Z

virttest/env_process.py

@@ -1227,6 +1227,17 @@ def preprocess(test, params, env):
    LOG.debug("KVM userspace version(qemu): %s", kvm_userspace_version)
    version_info["qemu_version"] = str(kvm_userspace_version)

+    #Get the SLOF version for power pc


For what I want is to let it be configurable, I have 2 ideas:

Get the firmware version for each platform:

ovmf, aarch64: check edk2 version

PC machine: check seabios

PPC: check SLOF

s390x: I don't know which one

Make all collection versions can be customizable, qemu/kvm/libvirt/swtpm/firmware...

Cc @luckyh @YongxueHong

Hi all,
I listed the build info for all arches and feel free to let me know if there's any missing.
1.
aarch64: edk2
x86_64: both seabios and edk2
s390x: need to confirm with bfu
2.
swtpm for all arches.

PaulYuuu · 2023-10-24T06:14:44Z

virttest/env_process.py

+            try:
+                slof_version = a_process.run(
+                    slof_ver_cmd, shell=True).stdout_text.strip()
+                LOG.debug("SLOF version: %s", slof_version)


Save to version_info["firmware_version"]

Updated, thanks.

maxujun · 2023-10-31T05:49:09Z

LGTM for power side.

YongxueHong · 2023-11-16T03:04:26Z

virttest/env_process.py

+                slof_version = a_process.run(
+                    slof_ver_cmd, shell=True).stdout_text.strip()
+                LOG.debug("SLOF version: %s", slof_version)
+                version_info["firmware_version"] = str(slof_version)


I think it is not a good way to classify them as firmware_version since the firmware concept is a bit general.
As we know, the firmware includes lots kinds of devices, like GPU, sound card, RAID controller card, and so on. It's hard to represent all the kinds of firmware with the firmware_version which looks general.
I would like to add the keyword slof, like firmware_slof_version or just slof_version .
Please let me know your opinions. @PaulYuuu @MiriamDeng
Thanks.

I prefer firmware_version to be an entry. And introduce a parameter to choose which firmware needs to be checked. But as I mentioned above, if we support custom components, we don't need a common name, can use the component name directly.

components_ver_check = qemu libvirt qemu_ver_cmd = libvirt_ver_cmd = ppc64le: components_ver_check += " slof" slof_ver_cmd = aarch64, q35: components_ver_check += " edk2" edk2_ver_cmd =

for component in params.objects('components_ver_check'): cmd = params.get(f'{component}_ver_cmd') ver_info = process.getoutput(cmd) LOG.debug(f"{component} version: {ver_info}") version_info[f"{component}_version"] = ver_info

PaulYuuu · 2023-12-07T05:40:35Z

After a short offline discussion with @YongxueHong, we think can only collect the boot firmware for each platform on this PR. A possible name may be qemu_bios_version? As SLOF/edk2/seabios is used to boot up a VM.

In short, in py file, log and save qemu_bios_version, in cfg:

default_bios:
    x86, i386:
        qemu_bios_ver_cmd = 
	aarch64:
        qemu_bios_ver_cmd = 
	ppc64le, ppc64:
        qemu_bios_ver_cmd = 
	s390x, s390:
        qemu_bios_ver_cmd = 
ovmf:
	qemu_bios_ver_cmd =

What do you think @luckyh @MiriamDeng ?

MiriamDeng · 2023-12-07T05:43:47Z

Hi @PaulYuuu
Thanks for the the guideline , will update the patch very soon.
Thank you !

MiriamDeng · 2023-12-08T01:52:55Z

Test result (without internal cfg)
(1/1) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/1) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (810.21 s

PaulYuuu · 2023-12-08T01:29:38Z

virttest/shared/cfg/base.cfg

+#
+#Notes: please make sure the corresponding firmware before you set this value!
+#eg. for x86_64
+#bootloader = "rpm -qa|grep ^sea"


vm_bootloader_ver_cmd = xxx

Thanks, updated.

PaulYuuu · 2023-12-08T01:57:47Z

virttest/env_process.py

+            LOG.debug("vm_bootloader_version: %s", vm_bootloader_ver)
+            version_info["vm_bootloader_ver"] = str(vm_bootloader_ver)
+        except a_process.CmdError:
+            vm_bootloader_ver = "Unkown"


Even if the version is "Unknown", it can also be saved in the version_info, like qemu/libvirt doing.

Thanks, updated

MiriamDeng · 2023-12-08T07:49:12Z

Also created new patch for internal cfg( id:1241) in gitlab.

YongxueHong · 2023-12-11T02:25:22Z

virttest/env_process.py

@@ -1241,6 +1241,17 @@ def preprocess(test, params, env):
            test.cancel("Got host qemu version:%s, which is not in %s" %
                        (host_qemu, required_qemu))

+    # Get the version of bootloader
+    vm_bootloader_cmd = params.get("vm_bootloader", "")


Suggested change

vm_bootloader_cmd = params.get("vm_bootloader", "")

vm_bootloader_cmd = params.get("vm_bootloader_ver_cmd", "")

YongxueHong · 2023-12-11T02:27:01Z

virttest/env_process.py

+        except a_process.CmdError:
+            vm_bootloader_ver = "Unkown"
+        version_info["vm_bootloader_ver"] = str(vm_bootloader_ver)
+        LOG.debug("vm_bootloader_version: %s", vm_bootloader_ver)


Suggested change

LOG.debug("vm_bootloader_version: %s", vm_bootloader_ver)

LOG.debug("VM bootloader version: %s", vm_bootloader_ver)

Updated,thanks !

PaulYuuu · 2023-12-12T05:31:49Z

virttest/env_process.py

+                vm_bootloader_cmd, shell=True).stdout_text.strip()
+        except a_process.CmdError:
+            vm_bootloader_ver = "Unkown"
+        version_info["vm_bootloader_ver"] = str(vm_bootloader_ver)


vm_bootloader_version

Updated, thanks

MiriamDeng · 2023-12-14T10:31:03Z

Test results without internal cfg
(1/3) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.xxx.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/3) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.xxx.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (967.83 s)

YongxueHong · 2023-12-18T14:45:00Z

virttest/env_process.py

@@ -1244,6 +1244,17 @@ def preprocess(test, params, env):
            test.cancel("Got host qemu version:%s, which is not in %s" %
                        (host_qemu, required_qemu))

+    # Get the version of bootloader
+    vm_bootloader_cmd = params.get("vm_bootloader_ver_cmd", "")


Suggested change

vm_bootloader_cmd = params.get("vm_bootloader_ver_cmd", "")

vm_bootloader_ver_cmd = params.get("vm_bootloader_ver_cmd", "")

x86_64: seabios and edk2 ppc64, ppc64le: SLOF aarch64: edk2 Signed-off-by: Miriam Deng <[email protected]>

PaulYuuu reviewed Oct 24, 2023

View reviewed changes

MiriamDeng force-pushed the add_slof_info branch 5 times, most recently from 99244b5 to 415c0fc Compare October 24, 2023 07:44

YongxueHong reviewed Dec 6, 2023

View reviewed changes

MiriamDeng force-pushed the add_slof_info branch from 415c0fc to c455695 Compare December 8, 2023 01:00

MiriamDeng changed the title ~~SLOF:Add package info of SLOF for ppc~~ VM_bootloader:provide bootloader's version for each arch Dec 8, 2023

PaulYuuu reviewed Dec 8, 2023

View reviewed changes

MiriamDeng force-pushed the add_slof_info branch from c455695 to 26a5bcb Compare December 8, 2023 02:29

YongxueHong reviewed Dec 11, 2023

View reviewed changes

MiriamDeng force-pushed the add_slof_info branch from 26a5bcb to 945efe8 Compare December 12, 2023 04:04

PaulYuuu reviewed Dec 12, 2023

View reviewed changes

MiriamDeng force-pushed the add_slof_info branch from 945efe8 to dbd175e Compare December 14, 2023 01:24

YongxueHong reviewed Dec 18, 2023

View reviewed changes

VM_bootloader:provide bootloader's version for each arch

936fb66

x86_64: seabios and edk2 ppc64, ppc64le: SLOF aarch64: edk2 Signed-off-by: Miriam Deng <[email protected]>

MiriamDeng force-pushed the add_slof_info branch from dbd175e to 936fb66 Compare December 19, 2023 03:04

YongxueHong approved these changes Dec 19, 2023

View reviewed changes

PaulYuuu approved these changes Dec 19, 2023

View reviewed changes

YongxueHong merged commit fca87a6 into avocado-framework:master Dec 19, 2023
49 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VM_bootloader:provide bootloader's version for each arch #3786

VM_bootloader:provide bootloader's version for each arch #3786

MiriamDeng commented Oct 23, 2023

MiriamDeng commented Oct 23, 2023 •

edited

Loading

MiriamDeng commented Oct 24, 2023

PaulYuuu Oct 24, 2023

MiriamDeng Dec 1, 2023

PaulYuuu Oct 24, 2023

MiriamDeng Oct 24, 2023

maxujun commented Oct 31, 2023

YongxueHong Nov 16, 2023

PaulYuuu Dec 7, 2023

PaulYuuu commented Dec 7, 2023

MiriamDeng commented Dec 7, 2023

MiriamDeng commented Dec 8, 2023

PaulYuuu Dec 8, 2023

MiriamDeng Dec 8, 2023

PaulYuuu Dec 8, 2023

MiriamDeng Dec 8, 2023

MiriamDeng commented Dec 8, 2023 •

edited

Loading

YongxueHong Dec 11, 2023

YongxueHong Dec 11, 2023

MiriamDeng Dec 12, 2023

PaulYuuu Dec 12, 2023

MiriamDeng Dec 14, 2023

MiriamDeng commented Dec 14, 2023 •

edited

Loading

YongxueHong Dec 18, 2023

	vm_bootloader_cmd = params.get("vm_bootloader", "")
	vm_bootloader_cmd = params.get("vm_bootloader_ver_cmd", "")

	LOG.debug("vm_bootloader_version: %s", vm_bootloader_ver)
	LOG.debug("VM bootloader version: %s", vm_bootloader_ver)

	vm_bootloader_cmd = params.get("vm_bootloader_ver_cmd", "")
	vm_bootloader_ver_cmd = params.get("vm_bootloader_ver_cmd", "")

VM_bootloader:provide bootloader's version for each arch #3786

VM_bootloader:provide bootloader's version for each arch #3786

Conversation

MiriamDeng commented Oct 23, 2023

MiriamDeng commented Oct 23, 2023 • edited Loading

MiriamDeng commented Oct 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxujun commented Oct 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PaulYuuu commented Dec 7, 2023

MiriamDeng commented Dec 7, 2023

MiriamDeng commented Dec 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MiriamDeng commented Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MiriamDeng commented Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

MiriamDeng commented Oct 23, 2023 •

edited

Loading

MiriamDeng commented Dec 8, 2023 •

edited

Loading

MiriamDeng commented Dec 14, 2023 •

edited

Loading