CI: Ensure only supported configure options are used (--enable-option-checking=fatal) #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndim
force-pushed
the
enable-option-checking=fatal
branch
from
a6fd7ed to
65c837d
Compare
Collaborator
|
Looks good to me. |
Use the multi-line format to invoke configure with a long command line. This prepares for even longer command lines.
ndim
force-pushed
the
enable-option-checking=fatal
branch
from
65c837d to
8fc665f
Compare
Contributor
Author
|
Fixed commit message typo. |
The macos build's "brew install" command has developed a
build failure without us being involved at all:
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /opt/homebrew
Could not symlink bin/pkg-config
Target /opt/homebrew/bin/pkg-config
is a symlink belonging to [email protected]. You can unlink it:
brew unlink [email protected]
This makes the macos build work again and implements the suggestions
brew prints when installing bison and flex, regarding PATH, LDFLAGS,
and CPPFLAGS.
Abort autotools CI builds in case we give them an unsupported option. The default is to only warn, but the CI should catch mistakes.
ndim
force-pushed
the
enable-option-checking=fatal
branch
from
8fc665f to
172474a
Compare
Contributor
Author
Collaborator
|
Looks good. I will merge this one so that CI runs will be okay. |
Collaborator
|
I have not updated the NEWS file but we can add the two commits later. |
Collaborator
Please do - lest we forget. Best if the person carrying out the merge documents that in NEWS |
Collaborator
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that only supported
configureoptions are used in the CI builds, by adding--enable-option-checking=fatalto theconfigurecommand line (since Autoconf 2.62 from 2008 or something).To make this work at all, this PR first fixes the issue of the MacOS "brew install" command suddenly failing while installing
pkg-config.