Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable toolbar menus #263

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

MtDalPizzol
Copy link
Contributor

Allows to hide the toolbar for an even more minimalistic look.

image

Allows to hide the toolbar for an even more minimalistic look.
@awcodes
Copy link
Owner

awcodes commented Dec 18, 2023

I like where your head is at, but I'm hesitant to do this as it will remove the full screen, redo, undo, reset and paragraph options.

@MtDalPizzol
Copy link
Contributor Author

Well... I did this because I have a use case where those options are simply a huge overkill and getting rid of them was actually the very reason why I did this. And I think having this as a built in option instead of having to hack into CSS to hide the toolbar is a lot more simple and reusable. Also, at least from my "not profound" understanding of the package internals, I can't see any drawbacks for having this as an option.

@MtDalPizzol
Copy link
Contributor Author

Sorry.... I should have mention in the pull request itself that hiding those options was the reason for having this...

@awcodes
Copy link
Owner

awcodes commented Dec 19, 2023

Seems a little overkill to load all of the plugin's functionality to have a more simple user interface. I'm wondering if this might be better as a separate plugin, to keep the build size down. 🤔

@MtDalPizzol
Copy link
Contributor Author

MtDalPizzol commented Dec 19, 2023

No problem... In my case, I'm using several instances of TiptapEditor, each with it's own set of tools. And in the case of the image I attached, I'm using only 2 tools. So, this isn't really an issue for me. But I totally understand the concern...

@awcodes awcodes merged commit 6a35587 into awcodes:3.x Dec 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants