Handling uncaughtException in create-amplify command#2364
Handling uncaughtException in create-amplify command#2364PG-practice wants to merge 4 commits intoaws-amplify:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 416d4eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Instead of duplicating a lot of the code here, you can move the existing error handling from cli package to cli-core package. Both create-amplify and cli have dependencies on the cli-core package.
There was a problem hiding this comment.
Please remove the diff for this lock file. It should not be needed for this PR.
31741ed to
416d4eb
Compare
|
I really appreciate your comment. |
Re-open of #2045 because I mistakenly closed it.
Problem
Issue number, if available:
#825
Changes
In top-level error handling #865, parser and usageDataEmitter appears to be used for subcommands (e.g. ampx sandbox), so omit these parameters because
create-amplifycommand are not followed by subcommandsCorresponding docs PR, if applicable:
Validation
error_handler.tsand it's test cases are based on a similar issue fix top-level error handling #865Where should we create your project?prompt causes no error.Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.