feat: Add support for JS and TS interfaces/unions #930
+166
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorFix
commented
Feb 6, 2025
| @@ -216,6 +216,7 @@ const generateJavasScriptPreset = ( | |||
| filename: join(modelFolder, 'index.d.ts'), | |||
| config: { | |||
| ...options.config, | |||
| target: 'typescript', | |||
There was a problem hiding this comment.
Probably indeed not needed (js generator inherits ts). Removing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A PR has added support for unions and interfaces.
However, they were still not working for generating models for JS/TS -
index.js,index.d.ts, andschema.jsmetadata file.This PR aims to complete this work and add the necessary support
Codegen Paramaters Changed or Added
N/A
Issue #, if available
N/A
Description of how you validated changes
Updating and adding tests at the moment.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.