Closed
Conversation
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
dpilch
reviewed
Feb 19, 2025
|
|
||
| const BUCKET_TEST_REGEX = /test/; | ||
| const IAM_TEST_REGEX = /!RotateE2eAwsToken-e2eTestContextRole|-integtest$|^amplify-|^eu-|^us-|^ap-/; | ||
| const IAM_TEST_REGEX = /!RotateE2eAwsToken-e2eTestContextRole|-integtest|^amplify-|^eu-|^us-|^ap-/; |
There was a problem hiding this comment.
I think this regex is wrong. I'm not aware of any functionality of ! on its own. I think this would be matching the ! character literally.
| }) | ||
| .promise(); | ||
| } catch (e) { | ||
| if (e?.code === 'InvalidClientTokenId') { |
There was a problem hiding this comment.
IIUC this case there shouldn't be anything to cleanup anyway? Can you add to the error message that there isn't any additional cleanup needed?
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Added additional handling to invalid token scenarios in cleanup scripts, since some child test accounts do not have opt-in region enabled, and will encounter invalid token error.
Codegen Paramaters Changed or Added
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.