Skip to content

feat(rtn-passkeys): add android support - 3b #14393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feat/rtn-passkeys/3a-add-ios-support
Choose a base branch
from

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented May 17, 2025

Description of changes

The purpose of this PR is to add Android support for the React Native implementation of webauthn.

  • Adds kotlin class containing complementary getPasskey, createPasskey, and getIsPasskeySupported APIs
  • Adds corresponding unit tests for android implementation

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jjarvisp jjarvisp changed the title feat(rtn-passkeys): add android support feat(rtn-passkeys): add android support - 3b May 17, 2025
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/2-modify-existing-impl branch from abd18da to 8065ea4 Compare May 17, 2025 23:32
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/3b-add-android-support branch 2 times, most recently from e1d88f9 to fc8c647 Compare May 17, 2025 23:54
@jjarvisp jjarvisp changed the base branch from feat/rtn-passkeys/2-modify-existing-impl to feat/rtn-passkeys/3a-add-ios-support May 17, 2025 23:55
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/3a-add-ios-support branch from c993348 to 8669899 Compare May 20, 2025 17:13
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/3b-add-android-support branch from fc8c647 to 5d287ef Compare May 20, 2025 17:14
@jjarvisp jjarvisp marked this pull request as ready for review May 20, 2025 17:46
@jjarvisp jjarvisp requested a review from a team as a code owner May 20, 2025 17:46
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/3a-add-ios-support branch from 8669899 to b55f3a1 Compare May 21, 2025 23:57
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/3b-add-android-support branch 2 times, most recently from 5f34e78 to 7240b5a Compare May 22, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant