Skip to content

chore: resolutions audit and cleanup#2050

Closed
wlee221 wants to merge 15 commits intomainfrom
resolutions-cleanup
Closed

chore: resolutions audit and cleanup#2050
wlee221 wants to merge 15 commits intomainfrom
resolutions-cleanup

Conversation

@wlee221
Copy link
Contributor

@wlee221 wlee221 commented Jun 8, 2022

Description of changes

Removes unneeded resolutions.

Removed Resolutions

Here are the resolutions we removed per use case and why they were pinned.

Security vulnerabilities

We either no longer depend on them or no longer point to vulnerable version.

Broke CI/CD:

Unknown:

  • fs-extra Use aws-amplify/docs as foundation #75
    • This was initially pinned when docs poc first started. Not sure why it was pinned, but this does not block docs now. Considering we wrote a brand new ui.docs after it, I'm removing this.

Resolutions left:

Issue #, if available

Description of how you validated changes

e2e tests, and also ran docs locally. Note that resolutions only affects us (and docs), and not customer builds.

Also ran yarn audit, and confirmed there are no security errors (except the usual Next.js Image Optimization one).

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022

⚠️ No Changeset found

Latest commit: 88510b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wlee221 wlee221 changed the base branch from main to bump-angular-example June 8, 2022 00:29
@wlee221 wlee221 temporarily deployed to ci June 8, 2022 00:43 Inactive
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Edit: approved pending passing integ tests

@wlee221 wlee221 marked this pull request as draft June 8, 2022 01:33
@wlee221 wlee221 marked this pull request as ready for review June 8, 2022 08:04
@wlee221 wlee221 marked this pull request as draft June 8, 2022 08:05
Base automatically changed from bump-angular-example to main June 8, 2022 22:37
@wlee221 wlee221 temporarily deployed to ci June 8, 2022 22:56 Inactive
@wlee221 wlee221 temporarily deployed to ci June 8, 2022 22:56 Inactive
@wlee221 wlee221 temporarily deployed to ci June 8, 2022 22:56 Inactive
@wlee221 wlee221 temporarily deployed to ci June 8, 2022 22:56 Inactive
@wlee221 wlee221 marked this pull request as ready for review June 8, 2022 23:16
@wlee221 wlee221 changed the title chore: resolutions cleanup chore: resolutions audit and cleanup Jun 8, 2022
@wlee221
Copy link
Contributor Author

wlee221 commented Jun 8, 2022

yarn audit result:

image

@wlee221
Copy link
Contributor Author

wlee221 commented Jun 9, 2022

Holding this for later; Angular 13 bump changes needed to be reverted.

@wlee221 wlee221 closed this Jun 9, 2022
@wlee221 wlee221 deleted the resolutions-cleanup branch December 22, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants