Closed
Conversation
This reverts commit 60577f6.
|
calebpollman
approved these changes
Jun 8, 2022
Contributor
Author
reesscot
approved these changes
Jun 9, 2022
Contributor
Author
|
Holding this for later; Angular 13 bump changes needed to be reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of changes
Removes unneeded resolutions.
Removed Resolutions
Here are the resolutions we removed per use case and why they were pinned.
Security vulnerabilities
We either no longer depend on them or no longer point to vulnerable version.
ansi-regexForce ansi-regex@5.0.1 #522ansi-htmlFix Dependabot ANSI-HTML version #1500asyncadd a resolution for async #1682eventsourcefix(security): ping eventsource version to fix security#42 #1983glob-parentfix: update glob-parent used by angular build #1639json-schemafix: upgrading json-schema to 0.4.0 or later #865node-forgeResolvenode-forgedependabot issue #1582nth-checkfix: update nth-check dependency #1641trimfix: upgrading json-schema to 0.4.0 or later #865Broke CI/CD:
cssnano-preset-simplePin cssnano-simple to 3.0.0 #1513next.jslater pinned this on their end: srcprism-react-rendererPin prism-react-renderer to 1.2.1 #1273docs/package.json: srcUnknown:
fs-extraUse aws-amplify/docs as foundation #75docsnow. Considering we wrote a brand new ui.docs after it, I'm removing this.Resolutions left:
jest,ts-jest,ws(Vue: Add Way To Build Package #310)vue. Left as-is, knowing that vue tests are getting updated soon with Update Vue's testing library to use Vitest #1970. (cc @ErikCH)vscode-vue-languageservice(chore: Pin vscode-vue-languageservice to 0.27.26 #473)Issue #, if available
Description of how you validated changes
e2e tests, and also ran docs locally. Note that
resolutionsonly affects us (anddocs), and not customer builds.Also ran
yarn audit, and confirmed there are no security errors (except the usual Next.js Image Optimization one).Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.