feat: allow custom field on sign in#6581
Conversation
🦋 Changeset detectedLatest commit: 24b24bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hello @fmonper1, thank you for the PR we will have a look and update you as soon as we have an update. Can you meanwhile please clarify how/if you tested this end-to-end? |
|
Hey there @ahmedhamouda78 , I haven't been able to test this locally since I'm unable to run the example packages locally. I've been somewhat able to build the packages in the monorepo and I get some TS error related to this type https://github.com/aws-amplify/amplify-js/blob/main/packages/auth/src/providers/cognito/types/options.ts#L39-L46 not matching the signature of I'd be happy to add some test coverage If im able to run the examples locally |
Description of changes
This changes passes custom fields on the SignIn page to the relevant services.
Issue #, if available
#6570
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.