fix(ssr): remove mentioning of internal packages #8282
Conversation
src/pages/[platform]/build-a-backend/server-side-rendering/nuxt/index.mdx
Outdated
Show resolved
Hide resolved
| @@ -273,7 +270,7 @@ export default defineNuxtPlugin({ | |||
| ); | |||
|
|
|||
| // Create the libraryOptions object | |||
| const libraryOptions: LibraryOptions = { | |||
| const libraryOptions = { | |||
There was a problem hiding this comment.
is this type available from the main package?
There was a problem hiding this comment.
@josefaidt This type is not available in the main package. In this example it's not necessary, since tokenProvider and credentialsProvider are typed individually
| import { | ||
| createKeyValueStorageFromCookieStorageAdapter, | ||
| createUserPoolsTokenProvider, | ||
| createAWSCredentialsAndIdentityIdProvider, | ||
| runWithAmplifyServerContext | ||
| } from 'aws-amplify/adapter-core'; | ||
| import { parseAmplifyConfig } from 'aws-amplify/utils'; | ||
| import type { FetchAuthSessionOptions } from 'aws-amplify/auth'; |
There was a problem hiding this comment.
nit, can we move this type import above the value imports?
There was a problem hiding this comment.
@josefaidt sorted & grouped all the imports.
|
Is this PR for updating the content of https://docs.amplify.aws/gen1/react/build-a-backend/server-side-rendering/nuxt/? The changed file in this PR is not the page under gen1, it's for gen2, |
Description of changes:
The Nuxt SSR example refers to the internal-only package
@aws-amplify/core, which should not be used directly in customer apps. Updating the example to fix this issue.This change also fixed the incorrect import of
amplify_outputs.json.Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.