-
Notifications
You must be signed in to change notification settings - Fork 62
late initialize fields that get defaulted by AWS #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
late initialize fields that get defaulted by AWS #255
Conversation
4ba44d4 to
1724a63
Compare
1724a63 to
385c03a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… AWS Some spec fields get default values from AWS after they are created. These defaults cause the controller to keep requeuing, trying to set them to null. With these changes, we late initialize these fields, ensuring they are defaulted if the user does not define them
385c03a to
5f602da
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Other controllers exhibit similar behavior where diffs are detected and shouldn't be. Any plans to do this in more than just RDS controller? |
|
+1 for this change. Ran into a similar issue |
Issue #2695 && #2622
Description of changes:
Some spec fields get default values from AWS after they are created.
These defaults cause the controller to keep requeuing, trying to set
them to null. With these changes, we late initialize these fields,
ensuring they are defaulted if the user does not define them
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.