-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDK Code for provisioning ECS cluster with inf2.xlarge instance. #92
Open
ak-org
wants to merge
6
commits into
aws-neuron:master
Choose a base branch
from
ak-org:neuron-problem-detector
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial checkin.
Initialized folder and code.
Updated instructions and successfully tested the code.
can we get some eyes on this please? @aws-maens @natemail-aws @rgrandhiamzn |
mounchin
reviewed
Dec 2, 2024
mounchin
reviewed
Dec 2, 2024
mounchin
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clean up files not used and address the comments
neuron-problem-detector/ecs-npd-cdk/neuron_problem_detector/ecs_task_definition.json
Outdated
Show resolved
Hide resolved
neuron-problem-detector/ecs-npd-cdk/neuron_problem_detector/ecs_task_definition.json
Show resolved
Hide resolved
neuron-problem-detector/ecs-npd-cdk/neuron_problem_detector/neuron_problem_detector_stack.py
Show resolved
Hide resolved
...cs-npd-cdk/neuron_problem_detector/__pycache__/neuron_problem_detector_stack.cpython-311.pyc
Outdated
Show resolved
Hide resolved
...on-problem-detector/ecs-npd-cdk/neuron_problem_detector/__pycache__/__init__.cpython-311.pyc
Outdated
Show resolved
Hide resolved
neuron-problem-detector/ecs-npd-cdk/neuron_problem_detector/neuron_problem_detector_stack.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This project contains CDK code to provision :
Issue #, sim, or t.corp if available:
N/A
Link to RTD for my changes: https://github.com/aws-neuron/aws-neuron-samples-staging/YOUR_BRANCH_NAME/
Submitter Checklist
Tested on : Neuron SDK , release_version, Instance_type. N/A - Code is to deploy ECS Cluster with inf2.xlarge instances for Nodes.
I've completely filled out the form above!
**(MANDATORY) PR needs test run output
Reviewer Checklist
* I've verified the changes render correctly on RTD (link above)
* I've ensured the submitter completed the form
* (If appropriate) I've verified the metrics.json file provided by the submitter