Skip to content

Fix prometheus-sample-app deployment with build instructions#3152

Open
SurweeshSP wants to merge 1 commit intoaws-observability:mainfrom
SurweeshSP:fix/prometheus-sample-app-deployment-instructions
Open

Fix prometheus-sample-app deployment with build instructions#3152
SurweeshSP wants to merge 1 commit intoaws-observability:mainfrom
SurweeshSP:fix/prometheus-sample-app-deployment-instructions

Conversation

@SurweeshSP
Copy link
Copy Markdown

Problem

The prometheus-sample-app deployment YAML had an empty image: "" field, which prevented users from successfully deploying the sample application. This caused confusion as there were no instructions on how to obtain or build the required image.

Solution

  • Replaced empty image field with example image name: prometheus-sample-app:latest
  • Added detailed comments explaining how to build the image from source
  • Included direct link to the sample app source code in aws-otel-community repository
  • Provided a quick one-line Docker build command for convenience
  • Added imagePullPolicy: IfNotPresent to prevent image pull errors when using locally built images

Changes Made

  • Updated examples/eks/aws-prometheus/prometheus-sample-app.yaml
  • Added comprehensive inline documentation for building the sample app image

Testing

The YAML structure remains valid and users now have clear instructions to:

  1. Build the image from the provided source repository
  2. Deploy the sample app successfully to their EKS cluster

Related

This improves the developer experience for users testing ADOT with Prometheus metrics on EKS.

@SurweeshSP SurweeshSP requested a review from a team as a code owner December 24, 2025 08:08
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the stale label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant