Fix prometheus-sample-app deployment with build instructions#3152
Open
SurweeshSP wants to merge 1 commit intoaws-observability:mainfrom
Open
Fix prometheus-sample-app deployment with build instructions#3152SurweeshSP wants to merge 1 commit intoaws-observability:mainfrom
SurweeshSP wants to merge 1 commit intoaws-observability:mainfrom
Conversation
Contributor
|
This PR is stale because it has been open 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The prometheus-sample-app deployment YAML had an empty
image: ""field, which prevented users from successfully deploying the sample application. This caused confusion as there were no instructions on how to obtain or build the required image.Solution
prometheus-sample-app:latestimagePullPolicy: IfNotPresentto prevent image pull errors when using locally built imagesChanges Made
examples/eks/aws-prometheus/prometheus-sample-app.yamlTesting
The YAML structure remains valid and users now have clear instructions to:
Related
This improves the developer experience for users testing ADOT with Prometheus metrics on EKS.