Add ECS Fargate ephemeral storage metrics from Task Metadata Endpoint V4#3166
Open
neilkuan wants to merge 1 commit intoaws-observability:mainfrom
Open
Add ECS Fargate ephemeral storage metrics from Task Metadata Endpoint V4#3166neilkuan wants to merge 1 commit intoaws-observability:mainfrom
neilkuan wants to merge 1 commit intoaws-observability:mainfrom
Conversation
Vendor patch from opentelemetry-collector-contrib commit 0cf514fa0ab3. This adds support for EphemeralStorageMetrics from the ECS Task Metadata Endpoint V4, exposing two new task-level metrics: - container.ephemeral_storage.utilized (MiB) - container.ephemeral_storage.reserved (MiB) These metrics represent the shared ephemeral storage usage for Fargate tasks. Also fixes memory metrics unit from 'Megabytes' to 'MiB' for consistency. Upstream PR: open-telemetry/opentelemetry-collector-contrib#46414
Author
|
Hi @Kausik-A could you take a look this PR? thank you. |
Contributor
|
This PR is stale because it has been open 30 days with no activity. |
Author
|
Hi @Kausik-A could you take a look this PR? thank you. |
1 similar comment
|
Hi @Kausik-A could you take a look this PR? thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendor patch to add support for EphemeralStorageMetrics from the ECS Task Metadata Endpoint V4.
This is based on upstream commit
0cf514fa0ab3(open-telemetry/opentelemetry-collector-contrib#46414).Changes
Patched the following files in
vendor/:internal/aws/ecsutil/metadata.go— AddedEphemeralStorageMetricsstruct and field toTaskMetadatareceiver/awsecscontainermetricsreceiver/internal/awsecscontainermetrics/ecs_metrics.go— AddedEphemeralStorageUtilizedandEphemeralStorageReservedfields toECSMetricsreceiver/awsecscontainermetricsreceiver/internal/awsecscontainermetrics/accumulator.go— Populate ephemeral storage metrics from task metadatareceiver/awsecscontainermetricsreceiver/internal/awsecscontainermetrics/constant.go— Added metric attribute constants; fixed memory unit fromMegabytestoMiBreceiver/awsecscontainermetricsreceiver/internal/awsecscontainermetrics/translator.go— Emit ephemeral storage metrics at task level; appliedMiBunit fix for memory metricsNew Metrics
container.ephemeral_storage.utilizedcontainer.ephemeral_storage.reservedTesting
go build ./cmd/awscollector)ghcr.io/neilkuan/aws-otel-collector/aws-otel-collector:fixed