feat(cold-start-detection): Suppress cold start detection for non ON-DEMAND invocations #2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation (since there are no cold starts).
|
phipag
requested review from
hjgraca and
svozza
and removed request for
svozza
hjgraca
approved these changes
Dec 11, 2025
Contributor
|
@phipag since the CI is green and the PR approved, should we merge this before it drifts away? |
Contributor
Author
|
Good point. Let's merge this. Thanks for the reminder @dreamorosi . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is based on #2317 contributed by @Attyuttam.
They contributed the cold start detection algorithm for suppressing cold start detection on non ON-DEMAND invocations. This PR just gives some finishing touches on supporting it throughout other modules without breaking unit tests.
⭐ Big thanks to @Attyuttam!
Changes
Issue number: #2113
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.