Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin Core Implementation #185

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Bitcoin Core Implementation #185

wants to merge 34 commits into from

Conversation

racket2000
Copy link
Contributor

@racket2000 racket2000 commented Apr 1, 2025

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
  • Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
  • Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
  • Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

  • The tests for all current blueprints successfully complete before merge?
  • Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
  • Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
  • Mandatory for new node blueprints. The website builds without errors?

Additional Notes

N/A

Simon Goldberg and others added 12 commits March 28, 2025 17:05
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
Signed-off-by: racket2000 <[email protected]>
@racket2000
Copy link
Contributor Author

racket2000 commented Apr 1, 2025

When opening this PR, I initially kept encountering a "forbidden error" regarding the "camelcase" package for the Website Build check. I am not sure why. (An example of this error message can be seen here: https://github.com/aws-samples/aws-blockchain-node-runners/actions/runs/14201779886/job/39790220182)

Apologies for the numerous commits I made to troubleshoot this -- I had to do a bit of trial and error to refresh my package.json and package-lock.json in order to get past the Website Build check (which is strange, since the "camelcase" package is utilized in the website's package-lock.json)

For clarity, I am using a few packages for Bitcoin, such as aws-sdk/client-secrets-manager and base64url.

I have created a local package.json for Bitcoin, since the other Blueprints do not require these dependencies.

@frbrkoala frbrkoala self-assigned this Apr 1, 2025
@frbrkoala frbrkoala added the enhancement New feature or request label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants