Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional job document fields #115

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kstribrnAmzn
Copy link
Member

Description

FileType (for example) is optional in a job document. If the field exists, parse it. If not, skip it.

Testing

Executed updated unit tests per README instructions.

Issue

See #114

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

FileType (for example) is optional in a job document.
If the field exists, parse it. If not, skip it.
@kstribrnAmzn
Copy link
Member Author

Expecting memory stats to fail. I'll update this with the new memory footprint after the failure.

@kstribrnAmzn
Copy link
Member Author

Coverage is failing because the C compiler version file created by CMake cannot be found. It's expected in the build directory but has since moved to <build-dir>/MakeFiles/3.28.3/CompilerIdC/. Not sure why this is the case. I'm assuming it's due to the latest CMake version

24.04 currently includes a newer LCOV
verson which is incompatible with our current
setup
@kstribrnAmzn
Copy link
Member Author

       --branch-coverage
              Collect and/or retain branch coverage data.

              This is equivalent to using the option "--rc lcov_branch_coverage=1"; the option was added to better match the genhml interface.

Per the man page this is the same as --rc lcov_branch_coverage=1 but using this instead creates failures. Will leave Gaurav's commit as is. His works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants