Skip to content

Commit

Permalink
Improve reconnection behavior on signaling disconnection mid-meeting (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
hensmi-amazon authored Feb 5, 2025
1 parent 3c0a4b9 commit 5c3d224
Show file tree
Hide file tree
Showing 19 changed files with 3,663 additions and 3,609 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Improve reconnection behavior on signaling disconnection mid-meeting. When the websocket is irreversibly losts, the SDK will now reconnect immediately instead of waiting on ping-pongs.

### Fixed
- Ensure content share resolution is always within limits

Expand Down
2 changes: 1 addition & 1 deletion demos/browser/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6,712 changes: 3,354 additions & 3,358 deletions docs/assets/js/search.js

Large diffs are not rendered by default.

16 changes: 15 additions & 1 deletion docs/classes/audiovideocontrollerstate.html
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ <h3>Properties</h3>
<li class="tsd-kind-property tsd-parent-kind-class"><a href="audiovideocontrollerstate.html#icegatheringdurationms" class="tsd-kind-icon">ice<wbr>Gathering<wbr>Duration<wbr>Ms</a></li>
<li class="tsd-kind-property tsd-parent-kind-class"><a href="audiovideocontrollerstate.html#icegatheringstateeventhandler" class="tsd-kind-icon">ice<wbr>Gathering<wbr>State<wbr>Event<wbr>Handler</a></li>
<li class="tsd-kind-property tsd-parent-kind-class"><a href="audiovideocontrollerstate.html#indexframe" class="tsd-kind-icon">index<wbr>Frame</a></li>
<li class="tsd-kind-property tsd-parent-kind-class"><a href="audiovideocontrollerstate.html#issessionconnected" class="tsd-kind-icon">is<wbr>Session<wbr>Connected</a></li>
<li class="tsd-kind-property tsd-parent-kind-class"><a href="audiovideocontrollerstate.html#lastknownvideoavailability" class="tsd-kind-icon">last<wbr>Known<wbr>Video<wbr>Availability</a></li>
<li class="tsd-kind-property tsd-parent-kind-class"><a href="audiovideocontrollerstate.html#lastvideosubscriptionconfiguration" class="tsd-kind-icon">last<wbr>Video<wbr>Subscription<wbr>Configuration</a></li>
<li class="tsd-kind-property tsd-parent-kind-class"><a href="audiovideocontrollerstate.html#lastvideostoreceive" class="tsd-kind-icon">last<wbr>Videos<wbr>ToReceive</a></li>
Expand Down Expand Up @@ -420,6 +421,16 @@ <h3>index<wbr>Frame</h3>
</ul>
</aside>
</section>
<section class="tsd-panel tsd-member tsd-kind-property tsd-parent-kind-class">
<a name="issessionconnected" class="tsd-anchor"></a>
<h3>is<wbr>Session<wbr>Connected</h3>
<div class="tsd-signature tsd-kind-icon">is<wbr>Session<wbr>Connected<span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">boolean</span><span class="tsd-signature-symbol"> = false</span></div>
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/AudioVideoControllerState.ts#L202">src/audiovideocontroller/AudioVideoControllerState.ts:202</a></li>
</ul>
</aside>
</section>
<section class="tsd-panel tsd-member tsd-kind-property tsd-parent-kind-class">
<a name="lastknownvideoavailability" class="tsd-anchor"></a>
<h3>last<wbr>Known<wbr>Video<wbr>Availability</h3>
Expand Down Expand Up @@ -851,7 +862,7 @@ <h3>reset<wbr>Connection<wbr>Specific<wbr>State</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/AudioVideoControllerState.ts#L204">src/audiovideocontroller/AudioVideoControllerState.ts:204</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/AudioVideoControllerState.ts#L208">src/audiovideocontroller/AudioVideoControllerState.ts:208</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4>
Expand Down Expand Up @@ -935,6 +946,9 @@ <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</spa
<li class=" tsd-kind-property tsd-parent-kind-class">
<a href="audiovideocontrollerstate.html#indexframe" class="tsd-kind-icon">index<wbr>Frame</a>
</li>
<li class=" tsd-kind-property tsd-parent-kind-class">
<a href="audiovideocontrollerstate.html#issessionconnected" class="tsd-kind-icon">is<wbr>Session<wbr>Connected</a>
</li>
<li class=" tsd-kind-property tsd-parent-kind-class">
<a href="audiovideocontrollerstate.html#lastknownvideoavailability" class="tsd-kind-icon">last<wbr>Known<wbr>Video<wbr>Availability</a>
</li>
Expand Down
40 changes: 20 additions & 20 deletions docs/classes/defaultaudiovideocontroller.html

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions docs/classes/defaultsignalingclient.html
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ <h3>demote<wbr>From<wbr>Primary<wbr>Meeting</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/signalingclient.html">SignalingClient</a>.<a href="../interfaces/signalingclient.html#demotefromprimarymeeting">demoteFromPrimaryMeeting</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L513">src/signalingclient/DefaultSignalingClient.ts:513</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L522">src/signalingclient/DefaultSignalingClient.ts:522</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -264,7 +264,7 @@ <h3>mute</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/signalingclient.html">SignalingClient</a>.<a href="../interfaces/signalingclient.html#mute">mute</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L295">src/signalingclient/DefaultSignalingClient.ts:295</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L298">src/signalingclient/DefaultSignalingClient.ts:298</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -327,7 +327,7 @@ <h3>pause</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/signalingclient.html">SignalingClient</a>.<a href="../interfaces/signalingclient.html#pause">pause</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L304">src/signalingclient/DefaultSignalingClient.ts:304</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L307">src/signalingclient/DefaultSignalingClient.ts:307</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -385,7 +385,7 @@ <h3>promote<wbr>ToPrimary<wbr>Meeting</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/signalingclient.html">SignalingClient</a>.<a href="../interfaces/signalingclient.html#promotetoprimarymeeting">promoteToPrimaryMeeting</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L498">src/signalingclient/DefaultSignalingClient.ts:498</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L507">src/signalingclient/DefaultSignalingClient.ts:507</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -419,7 +419,7 @@ <h3>ready</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/signalingclient.html">SignalingClient</a>.<a href="../interfaces/signalingclient.html#ready">ready</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L289">src/signalingclient/DefaultSignalingClient.ts:289</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L292">src/signalingclient/DefaultSignalingClient.ts:292</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -536,7 +536,7 @@ <h3>resume</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/signalingclient.html">SignalingClient</a>.<a href="../interfaces/signalingclient.html#resume">resume</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L312">src/signalingclient/DefaultSignalingClient.ts:312</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/signalingclient/DefaultSignalingClient.ts#L315">src/signalingclient/DefaultSignalingClient.ts:315</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down
8 changes: 4 additions & 4 deletions docs/classes/meetingsessionstatus.html
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ <h3>is<wbr>Audio<wbr>Connection<wbr>Failure</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L59">src/meetingsession/MeetingSessionStatus.ts:59</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L60">src/meetingsession/MeetingSessionStatus.ts:60</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand Down Expand Up @@ -176,7 +176,7 @@ <h3>is<wbr>Terminal</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L39">src/meetingsession/MeetingSessionStatus.ts:39</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L40">src/meetingsession/MeetingSessionStatus.ts:40</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand Down Expand Up @@ -210,7 +210,7 @@ <h3><span class="tsd-flag ts-flagOptional">Optional</span> to<wbr>String</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L76">src/meetingsession/MeetingSessionStatus.ts:76</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L77">src/meetingsession/MeetingSessionStatus.ts:77</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">string</span></h4>
Expand All @@ -227,7 +227,7 @@ <h3><span class="tsd-flag ts-flagStatic">Static</span> from<wbr>Signal<wbr>Frame
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L133">src/meetingsession/MeetingSessionStatus.ts:133</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L136">src/meetingsession/MeetingSessionStatus.ts:136</a></li>
</ul>
</aside>
<h4 class="tsd-parameters-title">Parameters</h4>
Expand Down
Loading

0 comments on commit 5c3d224

Please sign in to comment.