Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event reporting usage to remove redundant code #3036

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hensmi-amazon
Copy link
Contributor

Issue #: None. I was going to extend some of these events and figured i could clean up the existing usage first.

Description of changes: Purely cosmetic. Change to using helper function for consistency.

Testing: I (+ gen AI) compared all events before and after change to confirm they had the same values.

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

Yes, but it takes a lot of log comparison so I won't recommend it here.

  1. Have you successfully run npm run build:release locally?

y

  1. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?

n

  1. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hensmi-amazon hensmi-amazon requested a review from a team as a code owner February 6, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant