Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Endpoint Ready Sync Issue via Update Trigger #327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jungrae-prestolabs
Copy link

Reproduction:

In endpointslice which gen by serviceImport

  1. Forcefully set conditions.ready to false.
  2. Even if the desired endpoint’s conditions.ready is true, it does not sync well

Deploy Scenario:

  1. During a rolling update of components (which has serviceExport), if the new endpoint does not pass the health check immediately, the MCS controller's fetch process publishes the endpoint to Cloudmap with ready: false.
  2. If the edge cluster fetches at that moment, it receives the status as ready: false.
  3. Subsequently, even if the actual state changes to ready: true, the ready status remains unsynced.

Solution:

Introduce a flag that triggers an update by setting ready to true whenever the existing state differs from the desired state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant