Skip to content

chore(dafny): make CI to work for all runtimes #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 12, 2025

Conversation

rishav-karanjit
Copy link
Member

@rishav-karanjit rishav-karanjit commented May 7, 2025

Description of changes:

  • Uncommenting other languages CI
  • For MPL test vectors keys.json, use extra .. for Go.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rishav-karanjit rishav-karanjit changed the title chore(dafny): fix test vectors path to work for all runtimes chore(dafny): fix test vectors path and CI to work for all runtimes May 7, 2025
@rishav-karanjit rishav-karanjit changed the title chore(dafny): fix test vectors path and CI to work for all runtimes chore(dafny): fix test vectors and CI to work for all runtimes May 7, 2025
@rishav-karanjit rishav-karanjit marked this pull request as ready for review May 7, 2025 20:28
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner May 7, 2025 20:28
@rishav-karanjit rishav-karanjit changed the title chore(dafny): fix test vectors and CI to work for all runtimes chore(dafny): run CI to work for all runtimes May 7, 2025
@rishav-karanjit rishav-karanjit changed the title chore(dafny): run CI to work for all runtimes chore(dafny): make CI to work for all runtimes May 7, 2025
Comment on lines +25 to +26
if OsLang.GetLanguageShort() == "Go" then
"../../../../" + mplKeysPath
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context: Go generates code into runtimes/go/<Implementation-From-Dafny> or <Test-From-Dafny>/. When we run make test_go, it runs from runtimes/go/Test-From-Dafny/. For all other runtimes it runs from runtimes/<runtime>

Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishav-karanjit rishav-karanjit merged commit d69f253 into Golang/reviewed May 12, 2025
49 checks passed
@rishav-karanjit rishav-karanjit deleted the Golang/fixTestVectorPath branch May 12, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants