Add AWSSDK.Signin dependency to resolve 'aws login' credentials#1011
Conversation
…tials The AWS SDK for .NET v4 resolves credentials from the AWS CLI v2 'aws login' SSO flow via SigninServiceClientHelpers, which reflectively loads the AWSSDK.Signin assembly at runtime. Without an explicit package reference the assembly is absent from the tool output, causing credential resolution to fail with "Assembly AWSSDK.Signin could not be found or loaded". Fixes #1010
There was a problem hiding this comment.
Pull request overview
Adds the missing AWS SDK runtime dependency needed for the AWS SDK credential chain to resolve credentials produced by the AWS CLI v2 aws login SSO flow (issue #1010). This prevents runtime failures where the SDK attempts to use Amazon.Runtime.Internal.SigninServiceClientHelpers but can’t load AWSSDK.Signin.
Changes:
- Add
AWSSDK.Signinas a dependency of theAWS.Deploy.CLItool to enable SSO credential resolution via the AWS SDK. - Add an Autover patch entry documenting the change for release notes/versioning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/AWS.Deploy.CLI/AWS.Deploy.CLI.csproj |
Adds AWSSDK.Signin package reference so the CLI can load the Signin helper used by the AWS SDK during credential resolution. |
.autover/changes/820ce536-653c-4f85-ba25-38489fd67ff2.json |
Adds a patch changelog entry describing the new dependency and the aws login credential resolution fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1011 +/- ##
===========================================
+ Coverage 35.05% 62.11% +27.06%
===========================================
Files 294 294
Lines 10813 10813
Branches 1615 1615
===========================================
+ Hits 3791 6717 +2926
+ Misses 6676 3494 -3182
- Partials 346 602 +256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue #, if available: #1010
Description of changes: Adds the
AWSSDK.Signinpackage so that the deploy tool can resolve credentials created viaaws login. Approach here is similar to aws/aws-lambda-dotnet#2391 but I only included the one package (I wasn't sure if other projects such asAWS.Deploy.CommonandAWS.Deploy.Orchestrationneeded to be changed too)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.