Skip to content

feat: remove Python3.7 support #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
- os: macos-latest
architecture: x64
python:
- 3.7
- 3.8
- 3.9
- "3.10"
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Getting Started
Required Prerequisites
======================

* Python 3.7+
* Python 3.8+


Installation
Expand Down
4 changes: 0 additions & 4 deletions buildspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ version: 0.2
batch:
fast-fail: false
build-list:
- identifier: python3_7
buildspec: codebuild/python3.7.yml
env:
image: aws/codebuild/standard:5.0
- identifier: python3_8
buildspec: codebuild/python3.8.yml
env:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ def get_requirements():
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: Implementation :: CPython",
"Topic :: Security",
"Topic :: Security :: Cryptography",
Expand Down
5 changes: 3 additions & 2 deletions src/dynamodb_encryption_sdk/compatability.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ def _warn_deprecated_python():
(3, 4): {"date": DEPRECATION_DATE_MAP["2.x"]},
(3, 5): {"date": "2021-11-10"},
(3, 6): {"date": "2021-12-19"},
(3, 7): {"date": "2024-03-04"},
}
py_version = (sys.version_info.major, sys.version_info.minor)
minimum_version = (3, 7)
minimum_version = (3, 8)

if py_version in deprecated_versions:
params = deprecated_versions[py_version]
Expand All @@ -36,5 +37,5 @@ def _warn_deprecated_python():
"bug fixes, and security updates please upgrade to Python {}.{} or "
"later. For more information, see SUPPORT_POLICY.rst: "
"https://github.com/aws/aws-dynamodb-encryption-python/blob/master/SUPPORT_POLICY.rst"
).format(py_version[0], py_version[1], minimum_version[0], minimum_version[1], params["date"])
).format(py_version[0], py_version[1], params["date"], minimum_version[0], minimum_version[1])
warnings.warn(warning, DeprecationWarning)
2 changes: 1 addition & 1 deletion test/unit/test_compatability.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class TestWarnDeprecatedPython:
def test_happy_version(self):
with mock.patch.object(sys, "version_info") as v_info:
v_info.major = 3
v_info.minor = 7
v_info.minor = 8
with pytest.warns(None) as record:
_warn_deprecated_python()
assert len(record) == 0
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
py{37,38,39,310,311,312}-{local,integ,ddb,examples}-fast,
py{38,39,310,311,312}-{local,integ,ddb,examples}-fast,
nocmk, sourcebuildcheck,
docs, bandit, doc8, readme,
flake8{,-tests,-examples}, pylint{,-tests,-examples},
Expand Down