Skip to content

Commit

Permalink
Merge branch 'aws:main' into benchmark/neuron-training
Browse files Browse the repository at this point in the history
  • Loading branch information
mattcjo authored Jan 10, 2025
2 parents 69a6007 + eed33db commit 05dbf30
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

## Installation

This project will use rolling releases going forward; we recommend fetching the latest commit:
```
go install github.com/aws/aws-k8s-tester/...@latest
go install github.com/aws/aws-k8s-tester/...@HEAD
```

## `kubetest2` deployers and testers for EKS
Expand Down Expand Up @@ -90,4 +91,4 @@ kubetest2 \
-- \
exec \
go test ./my/test/package
```
```
8 changes: 5 additions & 3 deletions internal/e2e/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
"io"
"os"

"github.com/aws/aws-k8s-tester/internal/e2e/mpioperator"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down Expand Up @@ -128,10 +130,10 @@ func GetJobLogs(restConfig *rest.Config, job k8s.Object) (string, error) {
return "", err
}
var jobLabel string
switch job.GetObjectKind().GroupVersionKind().Kind {
case "MPIJob":
switch job.(type) {
case *mpioperator.MPIJobFacade:
jobLabel = fmt.Sprintf("job-name=%s-launcher", job.GetName())
case "Job":
case *batchv1.Job:
jobLabel = fmt.Sprintf("job-name=%s", job.GetName())
default:
return "", fmt.Errorf("unsupported job type %T", job)
Expand Down

0 comments on commit 05dbf30

Please sign in to comment.