Add parallelism, stack status filter to janitor #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
force-pushed
the
janitor-workers
branch
2 times, most recently
from
c526fd3 to
0b60900
Compare
cartermckinnon
force-pushed
the
janitor-workers
branch
from
0b60900 to
5a9f532
Compare
cartermckinnon
changed the title
Issacwww
approved these changes
Jan 9, 2025
| var workers int | ||
| flag.IntVar(&workers, "workers", 1, "number of workers to processes resources in parallel") | ||
| var stackStatus string | ||
| flag.StringVar(&stackStatus, "stack-status", "", "only process stacks with a specific status") |
There was a problem hiding this comment.
:(, the DELETE_FAILED stack always need manual clean up for the VPC... which can only be deleted via console but not cli
There was a problem hiding this comment.
Yep that happens when the EKS-created cluster security group is left behind after the cluster is deleted. The console will delete it for you when you delete the VPC, but ec2:DeleteVpc won’t.
Our logic to sweep leaked ENIs is what prevents the SG from being left behind. We should scale down Auto nodes before deleting the cluster to make sure the SG is deleted along with the cluster IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds two features to the janitor:
--workersflag. Default is 1.--stack-status.nodeRoleNameto avoid errors when sweeping instance profiles.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.