Add module loading tests for user function #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxday
reviewed
Mar 12, 2025
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "aws-lambda-ric", | |||
| "version": "3.2.0", | |||
There was a problem hiding this comment.
This looks like a leftover from a previous bump? Maybe we should clearly state in the readme that package-lock should be commited
There was a problem hiding this comment.
Yes, Sure let me add it to the README.
There was a problem hiding this comment.
Updated README and the PR template.
maxday
approved these changes
Mar 12, 2025
| @@ -250,6 +251,166 @@ describe('UserFunction.load method', () => { | |||
|
|
|||
| response.should.be.resolvedWith('moon'); | |||
| }); | |||
|
|
|||
| it('should successfully load a CJS handler from extensionless file (no package.json)', async () => { | |||
trivenay
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add missing test scenarios:
Checklist
npm installto generate thepackage-lock.jsoncorrectly and included it in the PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.