Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update importlib-metadata to newest version #61

Open
iwanbolzern opened this issue Nov 2, 2021 · 4 comments
Open

Update importlib-metadata to newest version #61

iwanbolzern opened this issue Nov 2, 2021 · 4 comments

Comments

@iwanbolzern
Copy link

Hi all,

Is it possible to update the importlib-metadata dependency, so that it is again compatible with the newest version. Please see the error bellow if you try to use awslambdaric e.g. together with keyring (output of poetry):

Because no versions of awslambdaric match >2.0.0,<3.0.0
and awslambdaric (2.0.0) depends on importlib-metadata (>=2.0,<3.0), awslambdaric (>=2.0.0,<3.0.0) requires importlib-metadata (>=2.0,<3.0).
Because keyring (23.2.1) depends on importlib-metadata (>=3.6)
and no versions of keyring match >23.2.1,<24.0.0, keyring (>=23.2.1,<24.0.0) requires importlib-metadata (>=3.6).

Thanks in advance and all the best,
Iwan

DavidCain added a commit to DavidCain/aws-lambda-python-runtime-interface-client that referenced this issue Jul 1, 2022
This should complete a previous attempt to remove dependency on the
package, unblocking use of `awslambdaric` in projects that use a newer
version of `importlib-metadata`. Version 2 of `importlib-metadata` is
reasonably old - version 4.4 is present in Python 3.10 for instance.

Motivation for the change
=========================
I think issue aws#61 covers it well, but essentially it becomes difficult
to use `awslambdaric` in a virtualenv with other dependencies that
expect a newer version of `importlib-metadata`:

aws#61

`awslambdaric` isn't supposed to need `importlib-metadata` anyway
=================================================================
Previous work (in August of 2021, with version 1.2.2) removed all
dependency on the `importlib-metadata` package, but accidentally left
`importlib-metadata` as a full dependency of this package:

- aws#55

Most recent version still has `importlib-metadata` dependency
=============================================================
```
$ pip show awslambdaric
Name: awslambdaric
Version: 2.0.4
...
Requires: importlib-metadata, simplejson
```
@DavidCain
Copy link
Contributor

I put out a one-line PR to fix, but it turns out that this package actually doesn't need importlib-metadata at all!

Removing the importlib-metadata dependency will allow using this package with Python 3.7 (or an older, EOL Python) and a newer version of importlib-metadata.

@iwanbolzern
Copy link
Author

@DavidCain Thanks for looking into this and fixing it!

@DavidCain
Copy link
Contributor

Not fixed yet, sadly - needs maintainers to see the PR and release a new version of the package. But I appreciate it all the same. 😄

But for now, you should at least be able to work around this issue by using Python 3.8 or newer with awslambdaric!

@tylertrussell
Copy link

It looks like this is now merged-in, and all we need is a new version of the package released.

Who do we need to ask to make that happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants