Remove the importlib-metadata dependency #83
Conversation
This should complete a previous attempt to remove dependency on the package, unblocking use of `awslambdaric` in projects that use a newer version of `importlib-metadata`. Version 2 of `importlib-metadata` is reasonably old - version 4.4 is present in Python 3.10 for instance. Motivation for the change ========================= I think issue aws#61 covers it well, but essentially it becomes difficult to use `awslambdaric` in a virtualenv with other dependencies that expect a newer version of `importlib-metadata`: aws#61 `awslambdaric` isn't supposed to need `importlib-metadata` anyway ================================================================= Previous work (in August of 2021, with version 1.2.2) removed all dependency on the `importlib-metadata` package, but accidentally left `importlib-metadata` as a full dependency of this package: - aws#55 Most recent version still has `importlib-metadata` dependency ============================================================= ``` $ pip show awslambdaric Name: awslambdaric Version: 2.0.4 ... Requires: importlib-metadata, simplejson ```
|
I do recognize that this PR should likely increment |
|
Maintainers - is there any chance this (one-line) PR can get some eyes? It should be exceedingly safe, and for many people will fix the ability to use |
aws-lambda-runtimes
requested review from
carlzogh,
smirnoal and
SukanyaHanumanthu
|
@carlzogh @smirnoal and/or @SukanyaHanumanthu - sorry to ping, but is there any chance you could take a look? |
|
@keshayad - sorry to ping you, but can we get this released into PyPi sometime soon? it's preventing us from updating some important dependencies. |
|
@keshayad, I also have the same request as @tylertrussell. Could you please release this to PyPI? The pinning of importlib-metadata~=2.0 is also preventing us from updating some important dependencies. |
This should complete a previous attempt to remove dependency on the
package, unblocking use of
awslambdaricin projects that use a newerversion of
importlib-metadata. Version 2 ofimportlib-metadataisreasonably old - version 4.4 is present in Python 3.10 for instance.
Motivation for the change
I think issue #61 covers it well, but essentially it becomes difficult
to use
awslambdaricin a virtualenv with other dependencies thatexpect a newer version of
importlib-metadata:awslambdaricisn't supposed to needimportlib-metadataanywayPrevious work (in August of 2021, with version 1.2.2) removed all
dependency on the
importlib-metadatapackage, but accidentally leftimportlib-metadataas a full dependency of this package:Most recent version still has
importlib-metadatadependencyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
I've read
CONTRIBUTING.mdand believe this should be all that's needed for a PR, but please let me know if I'm missing anything!