Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging of unhandled Python 3.11 ExceptionGroups #161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Better logging of unhandled Python 3.11 ExceptionGroups #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion awslambdaric/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ def handle_event_request(

xray_fault = make_xray_fault(etype.__name__, str(value), os.getcwd(), tb_tuples)
error_result = make_error(
str(value), etype.__name__, traceback.format_list(tb_tuples), invoke_id
'; '.join(str(e) for e in flatten_exceptiongroup(value)),
etype.__name__, traceback.format_list(tb_tuples), invoke_id
)

if error_result is not None:
Expand Down Expand Up @@ -292,6 +293,14 @@ def make_xray_fault(ex_type, ex_msg, working_dir, tb_tuples):
return xray_fault


def flatten_exceptiongroup(e):
exceptions = [e]
if isinstance(e, BaseExceptionGroup):
for sube in e.exceptions:
exceptions.extend(flatten_exceptiongroup(sube))
return tuple(exceptions)


def extract_traceback(tb):
return [
(frame.filename, frame.lineno, frame.name, frame.line)
Expand Down
40 changes: 40 additions & 0 deletions tests/test_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,46 @@ def __init__(self, message):
self.assertEqual(len(xray_fault["paths"]), 1)
self.assertTrue(xray_fault["paths"][0].endswith(os.path.relpath(__file__)))

def test_handle_event_request_exception_group(self):
def raise_exception_handler(json_input, lambda_context):
try:
raise RuntimeError("Oops")
except Exception as e:
raise ExceptionGroup("We have nested exceptions", (e,))

file_path = os.path.relpath(__file__)
expected_response = {
"errorType": "ExceptionGroup",
"errorMessage": "We have nested exceptions (1 sub-exception); Oops",
"requestId": "invoke_id",
"stackTrace": [
f' File "{file_path}", line _, in raise_exception_handler\n'
' raise ExceptionGroup("We have nested exceptions", (e,))\n'
],
}
bootstrap.handle_event_request(
self.lambda_runtime,
raise_exception_handler,
"invoke_id",
self.event_body,
"application/json",
{},
{},
"invoked_function_arn",
0,
bootstrap.StandardLogSink(),
)
args, _ = self.lambda_runtime.post_invocation_error.call_args
error_response = json.loads(args[1])
self.assertEqual(args[0], "invoke_id")
error_response["stackTrace"] = [
re.sub(fr'".*/{file_path}"', f'"{file_path}"',
re.sub(r" line \d+,", " line _,", line)
)
for line in error_response["stackTrace"]
]
self.assertEqual(error_response.items(), expected_response.items())

def test_handle_event_request_no_module(self):
def unable_to_import_module(json_input, lambda_context):
import invalid_module # noqa: F401
Expand Down