-
Notifications
You must be signed in to change notification settings - Fork 313
Update tabulate requirement from >=0.8.2,<0.8.10 to >=0.8.8,<=0.8.10 #4475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tabulate requirement from >=0.8.2,<0.8.10 to >=0.8.8,<=0.8.10 #4475
Conversation
…in /cli Signed-off-by: chenwany <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-2.11 #4475 +/- ##
=============================================
Coverage 62.29% 62.29%
=============================================
Files 40 40
Lines 6314 6314
=============================================
Hits 3933 3933
Misses 2381 2381 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -1,5 +1,5 @@ | |||
boto3>=1.16.14 | |||
tabulate>=0.8.2,<0.8.10 | |||
tabulate>=0.8.8,<=0.8.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any specific reason to set the 0.8.10 as the last, what about tabulate>=0.8.8,<0.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our code, we have the third party licenses for version 0.8.10
https://github.com/aws/aws-parallelcluster/blob/develop/THIRD-PARTY-LICENSES.txt
Not sure if the licensing will change after 0.8.10. And we don't have version between 0.8.10 and 0.9 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of changes
from tabulate import tabulate
inaws-parallelcluster/cli/src/pcluster/cli_commands/update.py
, if the tabulate version <0.8.8, the import will fail with the following error in python 3.10:from tabulate import tabulate File "/home/conda/feedstock_root/build_artifacts/aws-parallelcluster_1666319446692/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.10/site-packages/tabulate.py", line 16, in <module> from collections import Iterable ImportError: cannot import name 'Iterable' from 'collections' (/home/conda/feedstock_root/build_artifacts/aws-parallelcluster_1666319446692/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.10/collections/__init__.py)
Tests
References
Checklist
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.