Skip to content

Update tabulate requirement from >=0.8.2,<0.8.10 to >=0.8.8,<=0.8.10 #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

chenwany
Copy link
Contributor

@chenwany chenwany commented Oct 21, 2022

Description of changes

  • Update tabulate requirement from >=0.8.2,<0.8.10 to >=0.8.8,<=0.8.10
  • We have from tabulate import tabulate in aws-parallelcluster/cli/src/pcluster/cli_commands/update.py, if the tabulate version <0.8.8, the import will fail with the following error in python 3.10:
    from tabulate import tabulate File "/home/conda/feedstock_root/build_artifacts/aws-parallelcluster_1666319446692/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.10/site-packages/tabulate.py", line 16, in <module> from collections import Iterable ImportError: cannot import name 'Iterable' from 'collections' (/home/conda/feedstock_root/build_artifacts/aws-parallelcluster_1666319446692/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.10/collections/__init__.py)
  • This is fixed in tabulate 0.8.8: Fix DeprecationWarning on Python 3.10 astanin/python-tabulate#105
  • We need to require the version to be larger than 0.8.8 to avoid the fail in python 3.10. Here's the error message from conda build with python 3.10: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=592951&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642
  • Update from <0.8.10 to <=0.8.10 because 0.8.10 is released

Tests

  • Describe the automated and/or manual tests executed to validate the patch.
  • Describe the added/modified tests.

References

  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chenwany chenwany requested a review from a team as a code owner October 21, 2022 18:40
@chenwany chenwany added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #4475 (93328b0) into release-2.11 (40c23df) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-2.11    #4475   +/-   ##
=============================================
  Coverage         62.29%   62.29%           
=============================================
  Files                40       40           
  Lines              6314     6314           
=============================================
  Hits               3933     3933           
  Misses             2381     2381           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chenwany chenwany added the 2.x label Oct 21, 2022
@@ -1,5 +1,5 @@
boto3>=1.16.14
tabulate>=0.8.2,<0.8.10
tabulate>=0.8.8,<=0.8.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any specific reason to set the 0.8.10 as the last, what about tabulate>=0.8.8,<0.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our code, we have the third party licenses for version 0.8.10

https://github.com/aws/aws-parallelcluster/blob/develop/THIRD-PARTY-LICENSES.txt

Not sure if the licensing will change after 0.8.10. And we don't have version between 0.8.10 and 0.9 now

Copy link
Contributor

@francesco-giordano francesco-giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenwany chenwany merged commit c132c33 into aws:release-2.11 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants