Skip to content

Commit b8b709c

Browse files
committed
Address TODOs
1 parent 077ed05 commit b8b709c

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

pom.xml

-11
Original file line numberDiff line numberDiff line change
@@ -536,17 +536,6 @@
536536
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:aws-sdk-java</ignoredUnusedDeclaredDependency>
537537
<!-- Declared by the codegen maven plugins (lite and normal). Not used directly but used to override a transitive dependecy -->
538538
<ignoredUnusedDeclaredDependency>org.codehaus.plexus:plexus-utils</ignoredUnusedDeclaredDependency>
539-
540-
<!-- TODO(post-sra-identity-auth): Once everything is switched to useSraAuth=true, remove this-->
541-
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>
542-
543-
<!-- TODO(post-sra-identity-auth): With move to SRA Identity & Auth, most clients won't need a
544-
dependency on auth module. But cannot remove it from services/pom.xml until all services
545-
have switched. Some service modules may still need it, because they have tests that use the
546-
old interfaces, but that should become a test scoped dependency in modules where needed.
547-
And the line below removed. -->
548-
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:auth</ignoredUnusedDeclaredDependency>
549-
550539
<!-- Ignoring any unused declared dependency warnings for access grants plugin across the bundle -->
551540
<ignoredUnusedDeclaredDependency>software.amazon.s3.accessgrants:*</ignoredUnusedDeclaredDependency>
552541
</ignoredUnusedDeclaredDependencies>

services/eventbridge/pom.xml

-8
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,6 @@
6767
<version>${awsjavasdk.version}</version>
6868
</dependency>
6969
<!-- Test Dependencies -->
70-
<!-- TODO(post-sra-identity-auth): auth-crt dependency can be removed as part of
71-
cleanup after all services are on SRA -->
72-
<dependency>
73-
<groupId>software.amazon.awssdk</groupId>
74-
<artifactId>auth-crt</artifactId>
75-
<version>${awsjavasdk.version}</version>
76-
<scope>test</scope>
77-
</dependency>
7870
<dependency>
7971
<groupId>software.amazon.awssdk</groupId>
8072
<artifactId>route53</artifactId>

services/transcribestreaming/pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@
5252
code that explicitly uses it -->
5353
<ignoredUnusedDeclaredDependencies>
5454
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth-aws-eventstream</ignoredUnusedDeclaredDependency>
55-
56-
<!-- TODO(post-sra-identity-auth): Once this module is switched to useSraAuth=true, remove this-->
57-
<!-- This ignore is already present in the root pom.xml, but seems like the
58-
ignoredUnusedDeclaredDependencies aren't merged. So repeating it here. -->
59-
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>
6055
</ignoredUnusedDeclaredDependencies>
6156
</configuration>
6257
</plugin>

0 commit comments

Comments
 (0)