-
Notifications
You must be signed in to change notification settings - Fork 910
Allow string value for select for enhanced query request #5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
3f602ae
066f000
b034c13
a7e960e
9bde83e
f11988f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"type": "feature", | ||
"category": "Amazon DynamoDB Enhanced Client", | ||
"contributor": "", | ||
"description": "Use String instead of Select enum for ProjectionExpression to support future values" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -311,6 +311,17 @@ public Builder select(Select select) { | |
return this; | ||
} | ||
|
||
/** | ||
* Determines the attributes to be returned in the result. See {@link Select} for examples and constraints. | ||
* If not found, returns {@link Select#UNKNOWN_TO_SDK_VERSION}. | ||
* @param select the selection criteria as a string | ||
* @return a builder of this type | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: this API doc seems to be copied from a getter, not setter? Can we update it |
||
public Builder select(String select) { | ||
this.select = Select.fromValue(select); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need to change the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed the implementation accordingly, please re-check - thanks! |
||
return this; | ||
} | ||
|
||
/** | ||
* The primary key of the first item that this operation will evaluate. By default, the operation will evaluate | ||
* the whole dataset. If used, normally this parameter is populated with the value that was returned for | ||
|
Uh oh!
There was an error while loading. Please reload this page.