Bump OpenRewrite to 3.6.1

[davidh44]

Motivation and Context

Continuation of #6040 to bump rewrite-recipe-bom to 3.6.1 (OpenRewrite v8.50.2)

Cannot bump to to latest 3.7.0 as JavaType.Method constructors were dropped, requires further refactoring in SDK recipes

Modifications

• Remove forked recipe ChangeMethodInvocationReturnType and use OpenRewrite one
• Remove adding L to content length arg in RequestBody.fromInputStream() as it is not necessary and breaks with the version bump
• Bump Maven integ tests to use rewrite-maven-plugin 6.6.0
• Bump Gradle integ tests to use rewrite-gradle-plugin 7.4.1

Testing

Ran end to end tests

[sonarqubecloud]

Quality Gate failed

Failed conditions
54.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[jhult]

@zoewangg, @Fred1155 - can this be merged?

[davidh44]

@zoewangg, @Fred1155 - can this be merged?

Hi @jhult , can I ask your motivation/use-case for the version bump in the SDK? The tool can be used standalone specifying the version the SDK supports, i.e., 5.46.0

• https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-tool.html

• aws-sdk-java-v2/test/v2-migration-tests/src/test/java/software/amazon/awssdk/v2migrationtests/MavenTestBase.java

  Line 58 in 3ec9f08

  String rewriteMavenPluginVersion = "5.46.0";

Reason for delay is we are facing difficulties with importing the newer versions of OpenRewrite dependencies internally. We hope to resolve and merge eventually but its not a priority for us at the moment.

[jhult]

@davidh44, thanks for the timely response. No worries if it can't be merged now.

I was hoping it would rectify the error I am getting:

mvn --errors org.openrewrite.maven:rewrite-maven-plugin:5.46.0:dryRun -Drewrite.recipeArtifactCoordinates=software.amazon.awssdk:v2-migration:2.31.58-PREVIEW -Drewrite.activeRecipes=software.amazon.awssdk.v2migration.AwsSdkJavaV1ToV2
...

[INFO] Using active recipe(s) [software.amazon.awssdk.v2migration.AwsSdkJavaV1ToV2]
[INFO] Using active styles(s) []
line 1:94 missing ')' at '<EOF>'
line 1:88 no viable alternative at input ', String, String'
line 1:88 no viable alternative at input ', String'
line 1:88 missing ')' at '<EOF>'
[INFO] Validating active recipes...

[sullis]

any updates here?

[sullis]

is this PR still active? any updates?

[davidh44]

We have bumped to rewrite-recipe-bom 3.14.0 with the GA release of our migration tool in SDK 2.34.0