-
Notifications
You must be signed in to change notification settings - Fork 932
Truncate to content in chunked publisher #6304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+452
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Fred1155
reviewed
Jul 29, 2025
...are/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java
Show resolved
Hide resolved
...va/software/amazon/awssdk/http/auth/aws/internal/signer/io/ContentLengthAwareSubscriber.java
Outdated
Show resolved
Hide resolved
...amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisherTest.java
Show resolved
Hide resolved
...va/software/amazon/awssdk/http/auth/aws/internal/signer/io/ContentLengthAwareSubscriber.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Jul 30, 2025
...va/software/amazon/awssdk/http/auth/aws/internal/signer/io/ContentLengthAwareSubscriber.java
Outdated
Show resolved
Hide resolved
...va/software/amazon/awssdk/http/auth/aws/internal/signer/io/ContentLengthAwareSubscriber.java
Outdated
Show resolved
Hide resolved
...are/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java
Show resolved
Hide resolved
Added |
zoewangg
reviewed
Jul 31, 2025
...are/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/ContentLengthAwareSubscriber.java
Outdated
Show resolved
Hide resolved
zoewangg
approved these changes
Jul 31, 2025
Fred1155
approved these changes
Jul 31, 2025
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
* Truncate to content in chunked publisher Add support for ensuring that the `ChunkedEncodedPublisher` on encodes a set number of bytes. * Review comments * Review comments * Review comments
Add support for ensuring that the `ChunkedEncodedPublisher` on encodes a set number of bytes.
2adef42
to
34fe82e
Compare
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
changelog-not-required
Indicate changelog entry is not required for a specific PR
no-api-surface-area-change
Indicate there is no API surface area change and thus API surface area review is not required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add support for ensuring that the
ChunkedEncodedPublisher
on encodes a set number of bytes.Modifications
Testing
ContentLengthAwareSubscriber
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License