Skip to content

Truncate to content in chunked publisher #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2025

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jul 28, 2025

Motivation and Context

Add support for ensuring that the ChunkedEncodedPublisher on encodes a set number of bytes.

Modifications

Testing

  • New unit tests
  • Add TCK test for ContentLengthAwareSubscriber

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jul 28, 2025
@dagnir dagnir requested a review from a team as a code owner July 28, 2025 23:35
@dagnir dagnir added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Jul 30, 2025
@dagnir
Copy link
Contributor Author

dagnir commented Jul 30, 2025

Added no-api-surface-area-change, ContentLengthAwareSubscriber is now @SdkProtectedApi, no API to review, just implements Subscriber<T>.

@dagnir dagnir enabled auto-merge July 31, 2025 22:47
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@dagnir dagnir added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@dagnir dagnir added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@dagnir dagnir added this pull request to the merge queue Aug 1, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2025
* Truncate to content in chunked publisher

Add support for ensuring that the `ChunkedEncodedPublisher` on encodes
a set number of bytes.

* Review comments

* Review comments

* Review comments
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
dagnir added 4 commits August 1, 2025 15:32
Add support for ensuring that the `ChunkedEncodedPublisher` on encodes
a set number of bytes.
@dagnir dagnir force-pushed the dongie/lengthaware-subscriber branch from 2adef42 to 34fe82e Compare August 1, 2025 22:32
@dagnir dagnir enabled auto-merge August 1, 2025 22:32
@dagnir dagnir added this pull request to the merge queue Aug 5, 2025
@dagnir dagnir removed this pull request from the merge queue due to a manual request Aug 5, 2025
@dagnir dagnir added this pull request to the merge queue Aug 5, 2025
Merged via the queue into master with commit 43f262c Aug 5, 2025
55 of 61 checks passed
Copy link

github-actions bot commented Aug 5, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants