Retry support for Java-based S3 multipart client for multipart GET to bytes #6328
+957
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidh44
changed the title
zoewangg
reviewed
Aug 12, 2025
| @@ -60,11 +63,30 @@ public void onStream(SdkPublisher<ByteBuffer> publisher) { | |||
| publisher.subscribe(new BaosSubscriber(cf)); | |||
| } | |||
|
|
|||
| public void onStream(SdkPublisher<ByteBuffer> publisher, long maximumBufferSize) { | |||
There was a problem hiding this comment.
Hmm, not sure if we want to add another onStream here, why do we need this?
There was a problem hiding this comment.
Was thinking to use maximumBufferSize for large part sizes, but ByteArrayAsyncResponseTransformer loads everything into memory anyways so its redundant. Will revert this addition
This reverts commit 1d136e5.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add retry support for Java-based S3 multipart client when multipart downloading with
ByteArrayAsyncResponseTransformerModifications
ByteArraySplittingTransformerSplittingTransformerbut eachIndividualTransformercreates a newByteArrayAsyncResponseTransformer, in order to support retriesByteArrayAsyncResponseTransformersplit()to useByteArraySplittingTransformerTesting
Add Wiremock tests and refactor existing tests
Types of changes