Fix StsWebIdentityTokenFileCredentialsProvider not respecting prefetchTime and staleTime configuration #6650
+126
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Saranya1
changed the title
S-Saranya1
changed the title
S-Saranya1
changed the title
davidh44
reviewed
Dec 31, 2025
Comment on lines
109
to
119
| credentialsProviderLocal = | ||
|
|
||
| StsAssumeRoleWithWebIdentityCredentialsProvider.Builder internalBuilder = | ||
| StsAssumeRoleWithWebIdentityCredentialsProvider.builder() | ||
| .stsClient(builder.stsClient) | ||
| .refreshRequest(supplier) | ||
| .build(); | ||
| .refreshRequest(supplier); | ||
|
|
||
| internalBuilder.staleTime(this.staleTime()) | ||
| .prefetchTime(this.prefetchTime()) | ||
| .asyncCredentialUpdateEnabled(this.asyncCredentialUpdateEnabled()); | ||
|
|
||
| credentialsProviderLocal = internalBuilder.build(); |
Contributor
There was a problem hiding this comment.
Any reason we need internalBuilder? Can we set the fields directly?
Contributor
Author
There was a problem hiding this comment.
Hmm no reason, yeah modified it to set the fields directly.
| @@ -131,6 +131,13 @@ public Duration prefetchTime() { | |||
| return prefetchTime; | |||
| } | |||
|
|
|||
| /** | |||
| * Whether the provider should fetch credentials asynchronously in the background. | |||
Contributor
There was a problem hiding this comment.
Can we specify the default value is false here too?
davidh44
approved these changes
Dec 31, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes GitHub issue #6185 where StsWebIdentityTokenFileCredentialsProvider ignores custom prefetchTime and staleTime configurations.
Modifications
staleTime,prefetchTime,asyncCredentialUpdateEnabled) to internalStsAssumeRoleWithWebIdentityCredentialsProvidersuper(constructor, provider)asyncCredentialUpdateEnabled()getter methodTesting
Added unit tests to validate custom configurations controls actual refresh behavior.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License