Skip to content

Enable MockHttpRequestFactory in non Net Framework targets #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

muhammad-othman
Copy link
Member

@muhammad-othman muhammad-othman commented Apr 14, 2025

Description

Currently MockHttpRequestFactory only works for .net framework, and since we eventually want to run tests in other targets, this PR enables MockHttpRequestFactory in non Net Framework targets.
This doesn't support custom responses yet.

Currently MockHttpRequestFactory is only working on the .NET Framework. To support running tests on additional target frameworks, this PR extends support for MockHttpRequestFactory to non-.NET Framework targets.

Note: Custom response handling is not implemented yet .

Motivation and Context

Running tests for non Net Framework targets.

Testing

  • Ran AWSSDK.Extensions solution tests locally.
  • DRY_RUN-7ee716c8-84d6-426c-a4fd-f058b3d959a8.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@muhammad-othman muhammad-othman force-pushed the muhamoth/enable-mock-httpHandler-request branch from 266de94 to c7c84ea Compare April 14, 2025 21:04
@muhammad-othman muhammad-othman force-pushed the muhamoth/enable-mock-httpHandler-request branch from c7c84ea to 4748ba6 Compare April 14, 2025 21:48
Copy link
Contributor

@AlexDaines AlexDaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally, passing in dryrun, limitations of current implementation are documented

LGTM ✅

@muhammad-othman muhammad-othman merged commit 92dc60f into v4-development Apr 17, 2025
1 check passed
@muhammad-othman muhammad-othman deleted the muhamoth/enable-mock-httpHandler-request branch April 17, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants