Updated Azure DevOps service connection instructions in README.md#579
Open
rchildress87 wants to merge 3 commits intoaws:masterfrom
Open
Updated Azure DevOps service connection instructions in README.md#579rchildress87 wants to merge 3 commits intoaws:masterfrom
rchildress87 wants to merge 3 commits intoaws:masterfrom
Conversation
Replaced some inaccurate instructions, replaced all references of service endpoint with service connection, added more verbosity to the service connection parameters section to make it more clear which parameters need to be filled out.
…g more consistent in new content.
Contributor
|
Thanks for this contribution! We appreciate the effort to disambiguate the docs. The changes look good to me- however- they seem to imply that setup with Microsoft Entra ID is required. I have found that I can use OIDC without this step. (example article https://aws.amazon.com/blogs/modernizing-with-aws/how-to-federate-into-aws-from-azure-devops-using-openid-connect/) What does this step achieve? AFAIK this only entertains accessing azure services with OIDC from the pipeline (which are usually unnecessary for AWS based tasks), but I am not confident about this. |
|
Please do not merge this. I like all of the edits apart from the massive deletion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced some inaccurate instructions, replaced all references of service endpoint with service connection, added more verbosity to the service connection parameters section to make it more clear which parameters need to be filled out.
Motivation
I tried to follow the instructions in order to create a new service connection for OIDC and found the instructions difficult to understand. In some situations, they were inaccurate or the terminology was incorrect.
Related Issue(s), If Filed
N/A
Testing
N/A
Checklist
npm run newChangeLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.