refactor(amazonq): Improve robustness of lsp installation process #6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
/runIntegrationTests |
justinmk3
reviewed
Jan 14, 2025
packages/amazonq/src/lsp/client.ts
Outdated
| // If the extension is launch in debug mode the debug server options are use | ||
| // Otherwise the run options are used | ||
| let serverOptions: ServerOptions = { | ||
| run: { module: serverPath, transport: TransportKind.ipc }, | ||
| debug: { module: serverPath, transport: TransportKind.ipc, options: debugOptions }, | ||
| } | ||
|
|
||
| const child = cp.spawn('node', [serverPath, ...debugOptions.execArgv]) | ||
| const child = cp.spawn(executablePaths.node, [serverPath, ...debugOptions.execArgv]) |
There was a problem hiding this comment.
if we can find a way to use our ChildProcess module, then after #6304 we get instrumentation for free :)
justinmk3
reviewed
Jan 14, 2025
| @@ -22,7 +25,21 @@ export class WorkspaceLSPResolver implements LspResolver { | |||
| new Range(supportedLspServerVersions) | |||
| ).resolve() | |||
|
|
|||
| const nodeName = | |||
| process.platform === 'win32' ? getNodeExecutableName() : `node-${process.platform}-${process.arch}` | |||
There was a problem hiding this comment.
would the node-platfor-arch logic fit into getNodeExecutableName ?
There was a problem hiding this comment.
For some reason this idea only exists for the workspace installer. I think the actual standard (which the actual codewhisperer language server uses) is just node.exe/node
justinmk3
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.