Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(amazonq): Add inline completion e2e tests #6486

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test(amazonq): Add inline completion e2e tests #6486

wants to merge 3 commits into from

Conversation

jpinkney-aws
Copy link
Contributor

Problem

  • we have no confidence checks on inline completion e2e flows
  • we want to use these tests to eventually verify that codewhisperer language server is behaving correctly

Solution

  • add e2e tests that focus on sending inputs to the text editor and seeing how it reacts. That way we can re-use these tests with the codewhisperer language server
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner February 3, 2025 16:57
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws jpinkney-aws changed the title tests(amazonq): Add inline completion e2e tests test(amazonq): Add inline completion e2e tests Feb 3, 2025
@jpinkney-aws jpinkney-aws reopened this Feb 3, 2025
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

4 similar comments
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner February 3, 2025 22:49
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

4 similar comments
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

It flaked 1 time over 30 executions (~10 requests + minimum/stable/insiders). I haven't been able to reproduce it again though

justinmk3
justinmk3 reviewed Feb 6, 2025
View reviewed changes
packages/amazonq/test/e2e/inline/inline.test.ts
@@ -0,0 +1,179 @@
/*!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is located at a new place, whereas all the other Q features are located in packages/amazonq/test/e2e/amazonq

maybe the e2e/amazonq/* files should be lifted up into this location (followup PR)? since the e2e/amazonq subdir seems redundant.

justinmk3
justinmk3 reviewed Feb 6, 2025
View reviewed changes
packages/amazonq/test/e2e/inline/inline.test.ts
Comment on lines +69 to +71
const ok = await waitUntil(
async () =>
globals.telemetry.logger.query({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't assertTelemetry() do this, or what is it missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertTelemetry does the querying but it doesn't wait for the event to appear as far as I can tell. I want the tests to explicitly wait until those telemetry events appear and then finally assert on them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpinkney-aws @justinmk3