refactor(logging): scope log messages to specific LSP using topic headers. #6526
Conversation
| | 'test' | ||
| | 'childProcess' | ||
| | 'lsp' | ||
| | 'QWorkspaceLsp' |
There was a problem hiding this comment.
should these be amazonqWorkspaceLSP or is that too long? I feel like we need to have conventions on whether we use q vs amazonq since both are used in the codebase 🤔
There was a problem hiding this comment.
That feels more consistent. Better to start verbose and look for opportunities to shorten later.
| } from 'aws-core-vscode/shared' | ||
| import path from 'path' | ||
|
|
||
| const manifestURL = 'https://aws-toolkit-language-servers.amazonaws.com/codewhisperer/0/manifest.json' | ||
| export const supportedLspServerVersions = '^2.3.0' | ||
|
|
||
| const logger = getLogger('amazonqLSP') |
There was a problem hiding this comment.
| const logger = getLogger('amazonqLSP') | |
| const logger = getLogger('amazonqLsp') |
|
|
||
| const manifestUrl = 'https://aws-toolkit-language-servers.amazonaws.com/q-context/manifest.json' | ||
| // this LSP client in Q extension is only going to work with these LSP server versions | ||
| const supportedLspServerVersions = '0.1.35' | ||
| const logger = getLogger('amazonqWorkspaceLSP') |
There was a problem hiding this comment.
amazonqWorkspaceIndexingLsp is too long, but probably "indexing" is the most important thing to call out?
| const logger = getLogger('amazonqWorkspaceLSP') | |
| const logger = getLogger('amazonqIndexingLsp') |
There was a problem hiding this comment.
Right now, indexing is the only action supported by this lsp, but I could imagine Q adding a feature that does other "work" within the workspace. Also, I think it might be best to keep it inline with the name field we use in the resolver here:
Perhaps we should pull these out somewhere to make them more discoverable, but that might involve a deeper refactor out of the scope here.
Problem
The log messages coming out of the LSP work do not make it clear which LSP its working with (Q Workspace or Q general).
Follow up from: #6385 (comment)
Solution
LogTopicfunctionality to scope these to specific LSP.feature/xbranches will not be squash-merged at release time.