feat(xgboost): add parallel support for XGBoost 3.0.5 alongside 3.2.0#6174
Open
Jyothirmaikottu wants to merge 1 commit into
Open
feat(xgboost): add parallel support for XGBoost 3.0.5 alongside 3.2.0#6174Jyothirmaikottu wants to merge 1 commit into
Jyothirmaikottu wants to merge 1 commit into
Conversation
e666b98 to
c0b7e15
Compare
Add infrastructure to build, test, and release XGBoost 3.0.5 in parallel with 3.2.0. This enables continued CVE patching and maintenance of the 3.0.5 image while the 3.2.0 image is the primary release. Changes: - Add docker/xgboost/3.0-5/ with Dockerfile and requirements.txt restored from the last 3.0.5 state (commit fa20102), pinned to sagemaker-xgboost-container release-3.0.5 branch - Add .github/config/image/sagemaker-xgboost-3.0.yml config - Add .github/workflows/dispatch-release-sagemaker-xgboost-3.0.yml - Update reusable integ tests workflow with --xgboost-version input - Update PR workflow to detect 3.2.0 vs 3.0.5 vs shared resource changes - Version-gate tests with --xgboost-version pytest flag: - Pipe mode tests: restored, skipped on >= 3.2.0 - GPU tree_method: dynamic via gpu_tree_method fixture - xfail markers: gated to 3.2.0 only - generate_models.py: pickle vs save_model via XGBOOST_VERSION env var - Fix prod_image tag format in 3.2.0 config
c0b7e15 to
71cbd11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add infrastructure to build, test, and release XGBoost 3.0.5 in parallel with 3.2.0. This enables continued CVE patching and maintenance of the 3.0.5 image while the 3.2.0 image is the primary release.
Changes:
Purpose
Test Plan
Test Result
Toggle if you are merging into master Branch
By default, docker image builds and tests are disabled. Two ways to run builds and tests:
How to use the helper utility for updating dlc_developer_config.toml
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = truesagemaker_local_tests = trueHow to use PR description
Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:# /buildspec <buildspec_path># /buildspec pytorch/training/buildspec.yml# /tests <test_list># /tests sanity security ec2sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).