Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image-builder: Update kernel and keep only 1 kernel on redhat machines #2770

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

vignesh-goutham
Copy link
Member

@vignesh-goutham vignesh-goutham commented Dec 14, 2023

Description of changes:
Image builder was excluding kernel updates till now. With this change, image builder will update kernels and reboot into the new kernel. Post reboot, if the OS has more than 1 kernel, this change will remove all non-live kernels running on the RHEL machine.

Testing
Running image builder with changes output

    qemu: TASK [node : Get the list of installed kernels] ********************************
    qemu: changed: [default]
    qemu:
    qemu: TASK [node : Get the current running kernel] ***********************************
    qemu: changed: [default]
    qemu:
    qemu: TASK [node : Set the number of kernels to keep] ********************************
    qemu: ok: [default]
    qemu:
    qemu: TASK [node : Filter out the current kernels] ***********************************
    qemu: ok: [default]
    qemu:
    qemu: TASK [node : Remove old kernels] ***********************************************
    qemu: ok: [default] => (item=['4.18.0-372.9.1.el8'])

/hold

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added do-not-merge/hold size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2023
@vignesh-goutham
Copy link
Member Author

/unhold

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a3d3172 into aws:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants