Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up Rufio and Tink versions #4131

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

rahulbabu95
Copy link
Member

@rahulbabu95 rahulbabu95 commented Dec 14, 2024

Issue #, if available:

Description of changes:

  • Bump up Rufio version to the latest version as current version panics with the below error. The latest version has the fix included for the panic which stems from bmclib package
{"level":"info","controller":"machine","controllerGroup":"bmc.tinkerbell.org","controllerKind":"Machine","Machine":{"name":"bmc-eksa-ci15","namespace":"eksa-system"},"namespace":"eksa-system","name":"bmc-eksa-ci15","reconcileID":"aeecf99e-7a3d-44a7-9729-8773ca991c3e","v":0,"logger":"controllers/Machine","caller":"github.com/tinkerbell/rufio/controller/machine.go:69","time":"2024-12-13T05:51:46Z","message":"reconciling machine"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x18308bc]
  • Bump up Tinkerbell/tink to the latest version
    • Remove makefile targets and scripts that call upstream target release-manifest as this outputs a manifest tink.yaml which has all the tink-controller crds, supporting service account and roles, which we do not seem to be consuming anywhere. We install tink crds directly through a separate helm chart that we build.
    • Remove all the patches to upstream as they were all concerned to only running this make target.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 14, 2024
@rahulbabu95
Copy link
Member Author

/retest

@rahulbabu95
Copy link
Member Author

/retest

1 similar comment
@rahulbabu95
Copy link
Member Author

/retest

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 3d81c82 into aws:main Dec 17, 2024
4 checks passed
@rahulbabu95 rahulbabu95 changed the title Bump down Rufio and bump up Tink versions Bump up Rufio and Tink versions Dec 17, 2024
@rahulbabu95 rahulbabu95 deleted the l3/bump-tink branch December 17, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants