Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.23 to final stage in builder-base Dockerfile #1524

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

abhay-krishna
Copy link
Member

  • Add Go 1.23 to final stage in builder-base Dockerfile so that it's available in the final output image
  • Sort keys in versions.yaml tracker file, also add logic to the Golang version check script to handle this

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -8,23 +8,23 @@ GOLANG_VERSION_119: 1.19.13-14
GOLANG_VERSION_120: 1.20.14-16
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are purely cosmetic, just alphabetical sorting.

@varma-maryala
Copy link
Member

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varma-maryala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 977c03a into aws:main Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants