Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python packages are incompatible with the binary distribution format specification #4790

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

Leo10Gama
Copy link
Member

Due to recent PyPI distributions failing the binary distribution format, setuptools put out a new version to ensure the .whl file is named correctly. This change bumps our version of the tool to use this latest version, ensuring distributions done via jsii-pacmak follow the convention.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama
Copy link
Member Author

Confirmed locally that this version updates correctly using an alpha module in CDK lib:

Prev: aws_cdk.aws_cognito_identitypool_alpha-... .whl
Curr: aws_cdk_aws_cognito_identitypool_alpha-... .whl

image

@Leo10Gama Leo10Gama marked this pull request as ready for review March 12, 2025 18:49
@mrgrain mrgrain changed the title chore: bump setuptools version fix: bump setuptools version Mar 13, 2025
@mrgrain mrgrain changed the title fix: bump setuptools version fix: python packages are incompatible with the binary distribution format specification Mar 13, 2025
Copy link
Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 13, 2025
Copy link
Contributor

mergify bot commented Mar 13, 2025

Merging (with squash)...

@mergify mergify bot merged commit 0ba5e81 into aws:main Mar 13, 2025
33 checks passed
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants