feat: Support preview instances without pricing data#8957
Open
azishabibi wants to merge 1 commit intomainfrom
Open
feat: Support preview instances without pricing data#8957azishabibi wants to merge 1 commit intomainfrom
azishabibi wants to merge 1 commit intomainfrom
Conversation
- Assign high price (1e9) to on-demand preview instances without pricing - Use price-capacity-optimized allocation when prioritized overrides exist - Add test coverage for instances without pricing data - Only apply to on-demand; spot instances without zonal pricing remain unavailable
Contributor
|
Preview deployment ready! Preview URL: https://pr-8957.d18coufmbnnaag.amplifyapp.com Built from commit |
Pull Request Test Coverage Report for Build 21881034082Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #N/A
Description
This PR enables Karpenter to handle preview instances that don't have pricing data available yet. Preview instances are now assigned a high price (1e9) for on-demand capacity, ensuring they're only selected when explicitly requested via instance type requirements. When these prioritized overrides are detected, the fleet automatically uses the price-capacity-optimized allocation strategy.
How was this change tested?
should assign high price to instances without pricing datathat verifies instances without pricing data receive the high price (1e9)Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.