fix(Grafana): Metric _pod_requests already include _daemon_requests#8965
Open
mkilchhofer wants to merge 1 commit intoaws:mainfrom
Open
fix(Grafana): Metric _pod_requests already include _daemon_requests#8965mkilchhofer wants to merge 1 commit intoaws:mainfrom
_pod_requests already include _daemon_requests#8965mkilchhofer wants to merge 1 commit intoaws:mainfrom
Conversation
_pod_requests already include _daemon_requests
Author
|
I am not sure how far this change goes back, I can only confirm that both 1.9 and 1.8 were affected since we at @swisspost used both versions and both had this behavior. So I adapted the dashboards for
There are other dashboard Jsons with the old formula where I am not sure if metrics once were handled different
|
Signed-off-by: Marco Maurer <marco.maurer.1@post.ch>
eafdcfb to
3451e22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7407
Description
The dashboards provided on the website (https://karpenter.sh/docs/getting-started/getting-started-with-karpenter/#monitoring-with-grafana-optional) calculates the used capacity on the Karpenter-managed nodes.
For this, they currently use this forumla:
This formula is wrong as the metric
karpenter_nodes_total_pod_requestsalready include the requests of the DaemonSet pods according to the metrics documentation:How was this change tested?
Importing the old and the new dashboard into our Grafana Cloud instance and compared the results:
Old:

New:

Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.